[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Expose default Plasma theme to QML based KSplash
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2013-01-07 10:59:11
Message-ID: 20130107105911.10125.18164 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105761/#review24888
-----------------------------------------------------------
wouldn't it make more sense to simply use the Theme QML element from Plasma=
Core components?
- Aaron J. Seigo
On Dec. 19, 2012, 6:30 p.m., Nuno Bento wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105761/
> -----------------------------------------------------------
> =
> (Updated Dec. 19, 2012, 6:30 p.m.)
> =
> =
> Review request for Plasma and Ivan =C4=8Cuki=C4=87.
> =
> =
> Description
> -------
> =
> This patch modifies KSplashQML allowing it to exposes the default Plasma =
theme to QML splash screens. =
> The idea was taken from the work done by David Edmundson and Aur=C3=A9lie=
n G=C3=A2teau in LightDM-KDE.
> =
> Giving QML splash themes access to the default Plasma theme makes it poss=
ible to create themes that transition seamlessly to the desktop (for anyone=
using the default wallpaper). It also makes it possible to recreate the de=
fault KSplash theme in QML with 2 major benefits over the existing one: 1) =
the wallpaper image used is appropriate to the user's resolution and 2) the=
theme doesn't need to be modified between releases since it always uses th=
e wallpaper from the default Plasma theme.
> =
> I've already implemented and tested a recreation of the Default theme in =
QML and will post the patch if this one gets accepted.
> =
> =
> Diffs
> -----
> =
> ksplash/ksplashqml/CMakeLists.txt c2065d9 =
> ksplash/ksplashqml/SplashWindow.cpp 4417643 =
> =
> Diff: http://git.reviewboard.kde.org/r/105761/diff/
> =
> =
> Testing
> -------
> =
> 1. Applied path to new kde:kde-workspace clone
> 2. Compiled and installed ksplashqml
> 3. Modified Minimalistic theme to use Image as background with source set=
to plasmaTheme.wallpaperPath(screenSize)
> 4. Created another QML based theme similar to the Default one
> 5. Tested login with 2 different users using both themes
> =
> =
> Thanks,
> =
> Nuno Bento
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105761/">http://git.reviewboard.kde.org/r/105761/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">wouldn't it make \
more sense to simply use the Theme QML element from PlasmaCore components?</pre> <br \
/>
<p>- Aaron J.</p>
<br />
<p>On December 19th, 2012, 6:30 p.m., Nuno Bento wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Ivan Čukić.</div>
<div>By Nuno Bento.</div>
<p style="color: grey;"><i>Updated Dec. 19, 2012, 6:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch modifies KSplashQML allowing it to exposes the default Plasma \
theme to QML splash screens. The idea was taken from the work done by David \
Edmundson and Aurélien Gâteau in LightDM-KDE.
Giving QML splash themes access to the default Plasma theme makes it possible to \
create themes that transition seamlessly to the desktop (for anyone using the default \
wallpaper). It also makes it possible to recreate the default KSplash theme in QML \
with 2 major benefits over the existing one: 1) the wallpaper image used is \
appropriate to the user's resolution and 2) the theme doesn't need to be \
modified between releases since it always uses the wallpaper from the default Plasma \
theme.
I've already implemented and tested a recreation of the Default theme in QML and \
will post the patch if this one gets accepted.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Applied path to new kde:kde-workspace clone 2. Compiled and installed \
ksplashqml 3. Modified Minimalistic theme to use Image as background with source set \
to plasmaTheme.wallpaperPath(screenSize) 4. Created another QML based theme similar \
to the Default one 5. Tested login with 2 different users using both themes</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksplash/ksplashqml/CMakeLists.txt <span style="color: \
grey">(c2065d9)</span></li>
<li>ksplash/ksplashqml/SplashWindow.cpp <span style="color: \
grey">(4417643)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105761/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic