'=?utf-8?q?Review_Request=3A_Fix_bug=C2=A0289427_-_plasma-desktop_freezes_?= =?utf-8?q?when_selecting'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    =?utf-8?q?Review_Request=3A_Fix_bug=C2=A0289427_-_plasma-desktop_freezes_?= =?utf-8?q?when_selecting
From:       "Chao Feng" <rainofchaos () gmail ! com>
Date:       2013-01-03 4:13:56
Message-ID: 20130103041356.9357.19896 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108102/
-----------------------------------------------------------

Review request for Plasma.

Description
-------

Bug 289427 is caused by a endless loop when searching for lagrest suitable font.
If the largest size of current system font is still smaller than the shown area,
the font.pointSize is increased but the resulting size QRect is the same.
So the do...while loop will loop forever and consume 100% cpu runtime.

Fix:
Check whether the resulting QRect is still increasing. If not, end the loop.

This addresses bug 289427.
    http://bugs.kde.org/show_bug.cgi?id=289427

Diffs
-----

  plasma/generic/applets/digital-clock/clock.cpp 708cb1ed105d636d3568295b134f4bcb55c4dfd6 

Diff: http://git.reviewboard.kde.org/r/108102/diff/

Testing
-------

Tested ok on Arch Linux + KDE 4.9.95

Thanks,

Chao Feng

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108102/">http://git.reviewboard.kde.org/r/108102/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Chao Feng.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Bug 289427 is caused by a endless loop when searching for lagrest \
suitable font. If the largest size of current system font is still smaller than the \
shown area, the font.pointSize is increased but the resulting size QRect is the same.
So the do...while loop will loop forever and consume 100% cpu runtime.

Fix:
Check whether the resulting QRect is still increasing. If not, end the loop.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested ok on Arch Linux + KDE 4.9.95</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=289427">289427</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/digital-clock/clock.cpp <span style="color: \
grey">(708cb1ed105d636d3568295b134f4bcb55c4dfd6)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108102/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 