'Re: Review Request: Plasmate: Replace QDialogButtonBox with QVBoxLayout'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Plasmate: Replace QDialogButtonBox with QVBoxLayout
From:       "Antonis Tsiapaliokas" <kok3rs () gmail ! com>
Date:       2013-01-05 16:18:27
Message-ID: 20130105161827.7116.19741 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108115/
-----------------------------------------------------------

(Updated Jan. 5, 2013, 4:18 p.m.)

Review request for Plasma.

Description
-------

Hello,

In this patch i am replacing the QDialogButtonBox with theQVBoxLayout.
Also i have increase the size of the dialog, because it was too small for t=
he labels.

Diffs
-----

  plasmate/savesystem/commitdialog.cpp cf7cb1f =

Diff: http://git.reviewboard.kde.org/r/108115/diff/

Testing
-------

Screenshots
-----------

after
  http://git.reviewboard.kde.org/r/108115/s/980/
before
  http://git.reviewboard.kde.org/r/108115/s/981/

Thanks,

Antonis Tsiapaliokas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108115/">http://git.reviewboard.kde.org/r/108115/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated Jan. 5, 2013, 4:18 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,

In this patch i am replacing the QDialogButtonBox with theQVBoxLayout.
Also i have increase the size of the dialog, because it was too small for the \
labels.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasmate/savesystem/commitdialog.cpp <span style="color: \
grey">(cf7cb1f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108115/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/108115/s/980/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/05/commitdialog1_400x100.png" \
style="border: 1px black solid;" alt="after" /></a>

 <a href="http://git.reviewboard.kde.org/r/108115/s/981/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/05/commitdialog2_400x100.png" \
style="border: 1px black solid;" alt="before" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 