From kde-panel-devel  Tue Dec 25 21:43:56 2012
From: =?ISO-8859-1?B?VGhvbWFzIEz8Ymtpbmc=?= <thomas.luebking () gmail ! com>
Date: Tue, 25 Dec 2012 21:43:56 +0000
To: kde-panel-devel
Subject: =?UTF-8?B?UmU6IHBsYXNtYSBhbmQgbmV3IHNoYWRvdyBtZXNz?=
Message-Id: <9991c90b-68f7-4d8d-8958-3e52d8e6afa8 () gmail ! com>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=135647186818230

On Montag, 24. Dezember 2012 23:12:22 CEST, Weng Xuetian wrote:
> Hi Plasma world,
> As new shadow lands in KDE 4.10 RC1, some unintentional mess is introduced.
>
> https://bugs.kde.org/show_bug.cgi?id=311502
> https://bugs.kde.org/show_bug.cgi?id=311995

I doubt those have much relation, notably #311995 is not about shadows at all, but invocation of the non-ARGB theme under certain conditions.

> The problem is, custom widget using plasma svg doesn't get new shadow
> support automatically, some code must be written.

The problem of #311502 rather seems to be an insufficient repaint area - more related to bug #312168, i'd say.

Wild guess from your patch: don't remove the shadows before, but *after* the hiding (eventually "later", ie. in the deconstructor or on the destroyed signal) to avoid confusations between the deleted window size and the "dirty" area.

Cheers,
Thomas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel