From kde-panel-devel Tue Dec 25 14:43:49 2012 From: "Kai Uwe Broulik" Date: Tue, 25 Dec 2012 14:43:49 +0000 To: kde-panel-devel Subject: Review Request: Fix dismissing LastNotificationPopup often failing Message-Id: <20121225144349.21693.10290 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=135644665412412 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3545228630432231738==" --===============3545228630432231738== Content-Type: multipart/alternative; boundary="===============3077039338784824753==" --===============3077039338784824753== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107908/ ----------------------------------------------------------- Review request for Plasma and Marco Martin. Description ------- This patch disables the setCustomNotification while a button (close, next, = back) is pressed, to prevent popup re-shifting which seems to eat the click= ed event. Problem is more deep in Plasma but has been around since Plasma exists, so = this should fix it for the notifications. This addresses bug 311413. http://bugs.kde.org/show_bug.cgi?id=3D311413 Diffs ----- plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qm= l e63526b = Diff: http://git.reviewboard.kde.org/r/107908/diff/ Testing ------- kdialog --passivepopup "bla" click, closes. Thanks, Kai Uwe Broulik --===============3077039338784824753== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107908/

Review request for Plasma and Marco Martin.
By Kai Uwe Broulik.

Descripti= on 

This patch disables the setCustomNotification while a button=
 (close, next, back) is pressed, to prevent popup re-shifting which seems t=
o eat the clicked event.
Problem is more deep in Plasma but has been around since Plasma exists, so =
this should fix it for the notifications.

Testing <= /h1> 
kdialog --passivepopup "bla"
click, closes.
Bugs: 311413

Diffs=

  • plasma/generic/applets/notifications/contents/ui/LastNotificationPopup= .qml (e63526b)

View Diff
--===============3077039338784824753==-- --===============3545228630432231738== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============3545228630432231738==--