From kde-panel-devel Mon Dec 24 14:06:51 2012 From: "Commit Hook" Date: Mon, 24 Dec 2012 14:06:51 +0000 To: kde-panel-devel Subject: Re: Review Request: Make sure ksmserver ignores excluded apps when saving session Message-Id: <20121224140651.2587.72788 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=135635806323297 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2176004240502794223==" --===============2176004240502794223== Content-Type: multipart/alternative; boundary="===============3747609297411171555==" --===============3747609297411171555== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107276/#review23955 ----------------------------------------------------------- This review has been submitted with commit c7fc5ed96143d91e16787a7e231f2c87= e9fa2df5 by Jekyll Wu to branch KDE/4.10. - Commit Hook On Dec. 9, 2012, 7:50 a.m., Jekyll Wu wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107276/ > ----------------------------------------------------------- > = > (Updated Dec. 9, 2012, 7:50 a.m.) > = > = > Review request for kdelibs, Plasma and Lubo=C5=A1 Lu=C5=88=C3=A1k. > = > = > Description > ------- > = > It is easy to understand why the existing code (usually) fails: = > = > * Users are most likely to just specify short names, like "dolphin,gwen= view,okular,rekonq", instead of "/usr/bin/konsole,/usr/bin/gwenview,/usr/bi= n/okular,/usr/bin/rekonq" > = > * When ksmserver saves the session, it usually gets the full names, like= "/usr/bin/dolphin", unless you have started that dolphin instance by typin= g "dolphin" exactly in a shell. = > = > = > So there are four possible combinations : > = > 1). config uses short name, runtime gets short name (this guy starts ev= erything from konsole, never using kio/krun) > 2). config uses short name, runtime gets long name (I think this is the= most common one) > 3). config uses long name, runtime gets short name = > 4). config uses long name, runtime gets long name (I guess some users u= se this combination because they find only that way works after trying vari= ous workaround...) > = > The existing code works with 1) and 4), the patch now works with 1), 2) = and 4) . I don't know whether it make senses to support all combinations . > = > = > = > = > = > This addresses bug 242760. > http://bugs.kde.org/show_bug.cgi?id=3D242760 > = > = > Diffs > ----- > = > ksmserver/server.cpp a65b35a = > = > Diff: http://git.reviewboard.kde.org/r/107276/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Jekyll Wu > = > --===============3747609297411171555== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107276/

This revie=
w has been submitted with commit c7fc5ed96143d91e16787a7e231f2c87e9fa2df5 b=
y Jekyll Wu to branch KDE/4.10.

- Commit

On December 9th, 2012, 7:50 a.m., Jekyll Wu wrote:

Review request for kdelibs, Plasma and Lubo=C5=A1 Lu=C5=88=C3=A1k.

By Jekyll Wu.

Updated Dec. 9, 2012, 7:50 a.m.

Descripti= on

It is easy to understand why the existing code (usually) fai=
ls: =


  * Users are most likely to just specify short names, like "dolphin,g=
wenview,okular,rekonq", instead of "/usr/bin/konsole,/usr/bin/gwe=
nview,/usr/bin/okular,/usr/bin/rekonq"

 * When ksmserver saves the session, it usually gets the full names, like &=
quot;/usr/bin/dolphin", unless you have started that dolphin instance =
by typing "dolphin" exactly in a shell. =



So there are four possible combinations :

  1). config uses short name, runtime gets short name (this guy starts ever=
ything from konsole, never using kio/krun)
  2). config uses short name, runtime gets long name (I think this is the m=
ost common one)
  3). config uses long name, runtime gets short name =

  4). config uses long name, runtime gets long name (I guess some users use=
 this combination because they find only that way works after trying variou=
s workaround...)

The existing code works with 1) and 4), the patch now works  with 1), 2) an=
d 4) . I don't know whether it make senses to support all combinations .

Bugs: 242760

Diffs=

ksmserver/server.cpp (a65b35a)

--===============3747609297411171555==-- --===============2176004240502794223== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2176004240502794223==--