--===============7539736202935265232== Content-Type: multipart/alternative; boundary="===============4140641333383207776==" --===============4140641333383207776== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107743/#review23937 ----------------------------------------------------------- This review has been submitted with commit 579b860460dcd5c54352fb0a4201ece9= 55b2433b by Weng Xuetian to branch master. - Commit Hook On Dec. 23, 2012, 6:16 p.m., Xuetian Weng wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107743/ > ----------------------------------------------------------- > = > (Updated Dec. 23, 2012, 6:16 p.m.) > = > = > Review request for Plasma and Marco Martin. > = > = > Description > ------- > = > New qml notification doesn't show summary for last popup notification. Th= is patch add summary back. > = > = > This addresses bug 307670. > http://bugs.kde.org/show_bug.cgi?id=3D307670 > = > = > Diffs > ----- > = > plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.= qml e63526b = > plasma/generic/applets/notifications/contents/ui/NotificationDelegate/N= otificationDelegate.qml 9e4345a = > = > Diff: http://git.reviewboard.kde.org/r/107743/diff/ > = > = > Testing > ------- > = > No problem here. Looks ok. > = > = > Screenshots > ----------- > = > current appearance > http://git.reviewboard.kde.org/r/107743/s/899/ > = > = > Thanks, > = > Xuetian Weng > = > --===============4140641333383207776== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107743/ 

This revie=
w has been submitted with commit 579b860460dcd5c54352fb0a4201ece955b2433b b=
y Weng Xuetian to branch master.

- Commit


On December 23rd, 2012, 6:16 p.m., Xuetian Weng wrote:

Review request for Plasma and Marco Martin.
By Xuetian Weng.

Updated Dec. 23, 2012, 6:16 p.m.

Descripti= on 

New qml notification doesn't show summary for last popup=
 notification. This patch add summary back.

Testing <= /h1> 
No problem here. Looks ok.
Bugs: 307670

Diffs=

  • plasma/generic/applets/notifications/contents/ui/LastNotificationPopup= .qml (e63526b)
  • plasma/generic/applets/notifications/contents/ui/NotificationDelegate/= NotificationDelegate.qml (9e4345a)

View Diff

Screensho= ts

3D"current
--===============4140641333383207776==-- --===============7539736202935265232== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7539736202935265232==--