'Review Request: Move IconItem into MouseArea'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Move IconItem into MouseArea
From:       "Dmitry Ashkadov" <dmitry.ashkadov () rosalab ! ru>
Date:       2012-12-23 19:25:12
Message-ID: 20121223192512.24124.99163 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107886/
-----------------------------------------------------------

Review request for Plasma.

Description
-------

I've choosen konversatio for testing purpose. When I had clicked on konversation's \
tray icon, it gots higlighted. After mouse cursor had left systemtray, an icon of \
konversation was highlighted. I think, moving PlasmaCore.IconItem into MouseArea \
should fix bug.

This addresses bug 311961.
    http://bugs.kde.org/show_bug.cgi?id=311961

Diffs
-----

  plasma/generic/applets/systemtray/package/contents/ui/StatusNotifierItem.qml \
8c1af92 

Diff: http://git.reviewboard.kde.org/r/107886/diff/

Testing
-------

Thanks,

Dmitry Ashkadov

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107886/">http://git.reviewboard.kde.org/r/107886/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Dmitry Ashkadov.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I&#39;ve choosen konversatio for testing purpose. When I had clicked on \
konversation&#39;s tray icon, it gots higlighted. After mouse cursor had left \
systemtray, an icon of konversation was highlighted. I think, moving \
PlasmaCore.IconItem into MouseArea should fix bug.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=311961">311961</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/systemtray/package/contents/ui/StatusNotifierItem.qml \
<span style="color: grey">(8c1af92)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107886/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 