[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: add pager drag switch feature back
From: Luís_Gabriel_Lima <lampih () gmail ! com>
Date: 2012-12-22 2:27:13
Message-ID: 20121222022713.7919.42334 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107843/#review23821
-----------------------------------------------------------
Ship it!
I think we can improve this solution later using the dragndrop plugin [1] to keep the \
the event handling on the qml side.
[1] - http://quickgit.kde.org/?p=kde-runtime.git&a=tree&f=plasma%2Fdeclarativeimports%2Fdraganddrop
- Luís Gabriel Lima
On Dec. 22, 2012, 1:40 a.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107843/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2012, 1:40 a.m.)
>
>
> Review request for kde-workspace, Plasma and Aaron J. Seigo.
>
>
> Description
> -------
>
> when porting to qml this feature lost. this add the feature back, code is mostly \
> the old one, with some clean up
>
> This addresses bug 310475.
> http://bugs.kde.org/show_bug.cgi?id=310475
>
>
> Diffs
> -----
>
> plasma/desktop/applets/pager/pager.h 767b2dd
> plasma/desktop/applets/pager/pager.cpp 956bde2
>
> Diff: http://git.reviewboard.kde.org/r/107843/diff/
>
>
> Testing
> -------
>
> tested, no problem.
>
>
> Thanks,
>
> Xuetian Weng
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107843/">http://git.reviewboard.kde.org/r/107843/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think we can improve \
this solution later using the dragndrop plugin [1] to keep the the event handling on \
the qml side.
[1] - http://quickgit.kde.org/?p=kde-runtime.git&a=tree&f=plasma%2Fdeclarativeimports%2Fdraganddrop</pre>
<br />
<p>- Luís Gabriel</p>
<br />
<p>On December 22nd, 2012, 1:40 a.m., Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace, Plasma and Aaron J. Seigo.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Dec. 22, 2012, 1:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">when porting to qml this feature lost. this add the feature back, code \
is mostly the old one, with some clean up</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested, no problem.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=310475">310475</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/pager/pager.h <span style="color: \
grey">(767b2dd)</span></li>
<li>plasma/desktop/applets/pager/pager.cpp <span style="color: \
grey">(956bde2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107843/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic