--===============4514434987959473331==
Content-Type: multipart/alternative;
boundary="===============9184447739423636024=="
--===============9184447739423636024==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105761/
-----------------------------------------------------------
(Updated Dec. 19, 2012, 6:30 p.m.)
Review request for Plasma and Ivan =C4=8Cuki=C4=87.
Changes
-------
I found an old review to ksplash posted 4 months ago, but the groups wasn't=
set, so I imagine no-one here saw it.
I've abused my reviewboard super powers to add it.
Nuno Bento also wrote a clone of the existing KSplash air theme in QML whic=
h uses this patch. I guess it never got anywhere. I have a copy of it. If N=
uno doesn't reply to my emails, I'll post it to RB myself.
Description
-------
This patch modifies KSplashQML allowing it to exposes the default Plasma th=
eme to QML splash screens. =
The idea was taken from the work done by David Edmundson and Aur=C3=A9lien =
G=C3=A2teau in LightDM-KDE.
Giving QML splash themes access to the default Plasma theme makes it possib=
le to create themes that transition seamlessly to the desktop (for anyone u=
sing the default wallpaper). It also makes it possible to recreate the defa=
ult KSplash theme in QML with 2 major benefits over the existing one: 1) th=
e wallpaper image used is appropriate to the user's resolution and 2) the t=
heme doesn't need to be modified between releases since it always uses the =
wallpaper from the default Plasma theme.
I've already implemented and tested a recreation of the Default theme in QM=
L and will post the patch if this one gets accepted.
Diffs
-----
ksplash/ksplashqml/CMakeLists.txt c2065d9 =
ksplash/ksplashqml/SplashWindow.cpp 4417643 =
Diff: http://git.reviewboard.kde.org/r/105761/diff/
Testing
-------
1. Applied path to new kde:kde-workspace clone
2. Compiled and installed ksplashqml
3. Modified Minimalistic theme to use Image as background with source set t=
o plasmaTheme.wallpaperPath(screenSize)
4. Created another QML based theme similar to the Default one
5. Tested login with 2 different users using both themes
Thanks,
Nuno Bento
--===============9184447739423636024==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Review request for Plasma and Ivan =C4=8Cuki=C4=87.
By Nuno Bento.
Updated Dec. 19, 2012, 6:30 p.m.
Changes=
h1>
I found an old review to ksplash posted 4 months ago, but th=
e groups wasn't set, so I imagine no-one here saw it.
I've abused my reviewboard super powers to add it.
Nuno Bento also wrote a clone of the existing KSplash air theme in QML whic=
h uses this patch. I guess it never got anywhere. I have a copy of it. If N=
uno doesn't reply to my emails, I'll post it to RB myself.
|
Descripti=
on
This patch modifies KSplashQML allowing it to exposes the de=
fault Plasma theme to QML splash screens. =
The idea was taken from the work done by David Edmundson and Aur=C3=A9lien =
G=C3=A2teau in LightDM-KDE.
Giving QML splash themes access to the default Plasma theme makes it possib=
le to create themes that transition seamlessly to the desktop (for anyone u=
sing the default wallpaper). It also makes it possible to recreate the defa=
ult KSplash theme in QML with 2 major benefits over the existing one: 1) th=
e wallpaper image used is appropriate to the user's resolution and 2) t=
he theme doesn't need to be modified between releases since it always u=
ses the wallpaper from the default Plasma theme.
I've already implemented and tested a recreation of the Default theme i=
n QML and will post the patch if this one gets accepted.
|
Testing <=
/h1>
1. Applied path to new kde:kde-workspace clone
2. Compiled and installed ksplashqml
3. Modified Minimalistic theme to use Image as background with source set t=
o plasmaTheme.wallpaperPath(screenSize)
4. Created another QML based theme similar to the Default one
5. Tested login with 2 different users using both themes
|
Diffs=
- ksplash/ksplashqml/CMakeLists.txt (c2065d9=
)
- ksplash/ksplashqml/SplashWindow.cpp (44176=
43)
View Diff
|
--===============9184447739423636024==--
--===============4514434987959473331==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
--===============4514434987959473331==--