--===============7517021497364832356== Content-Type: multipart/alternative; boundary="===============8422176228281852625==" --===============8422176228281852625== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107394/#review23724 ----------------------------------------------------------- This review has been submitted with commit 2a1c6cc977c6cb134ad2b94b46d831b1= 5f33fd7b by Giorgos Tsiapaliokas to branch master. - Commit Hook On Dec. 10, 2012, 4:31 p.m., Giorgos Tsiapaliokas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107394/ > ----------------------------------------------------------- > = > (Updated Dec. 10, 2012, 4:31 p.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > What has been done in the refactoring > 1. replace QXmlStream* with QDom* > 2. remove the old replace-by-hand code > 3. simplify the code > 4. reduce the code > 7 files changed, 411 insertions(+), 576 deletions(-) > = > There is only one issue, kconfigxteditor won't reformat correctly the cur= rent namespaces of the XMLs > = > the above > xmlns:xsi=3D"http://www.w3.org/2001/XMLSchema-instance" > xsi:schemaLocation=3D"http://www.kde.org/standards/kcfg/1.0 > http://www.kde.org/standards/kcfg/1.0/kcfg.xsd" > > = > will become this, > > = > the issue is in the newline, by removing by hand with $EDITOR fixes the i= ssue. > = > = > Diffs > ----- > = > plasmate/editors/kconfigxt/kconfigxteditor.h e6cd65e = > plasmate/editors/kconfigxt/kconfigxteditor.cpp 6f585fc = > plasmate/editors/kconfigxt/kconfigxtreader.h 8e923e9 = > plasmate/editors/kconfigxt/kconfigxtreader.cpp 21ce6ea = > plasmate/editors/kconfigxt/kconfigxtwriter.h d3560cd = > plasmate/editors/kconfigxt/kconfigxtwriter.cpp 20d6459 = > plasmate/mainwindow.cpp ee2666f = > = > Diff: http://git.reviewboard.kde.org/r/107394/diff/ > = > = > Testing > ------- > = > In the attached image I have modified the main.xml of dictionary and it w= orks. > = > = > Thanks, > = > Giorgos Tsiapaliokas > = > --===============8422176228281852625== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107394/ 

This revie=
w has been submitted with commit 2a1c6cc977c6cb134ad2b94b46d831b15f33fd7b b=
y Giorgos Tsiapaliokas to branch master.

- Commit


On December 10th, 2012, 4:31 p.m., Giorgos Tsiapaliokas wrote:

Review request for Plasma.
By Giorgos Tsiapaliokas.

Updated Dec. 10, 2012, 4:31 p.m.

Descripti= on 

What has been done in the refactoring
1. replace QXmlStream* with QDom*
2. remove the old replace-by-hand code
3. simplify the code
4. reduce the code
7 files changed, 411 insertions(+), 576 deletions(-)

There is only one issue, kconfigxteditor won't reformat correctly the c=
urrent namespaces of the XMLs

the above
<kcfg xmlns=3D"http://www.kde.org/standards/kcfg/1.0"
      xmlns:xsi=3D"http://www.w3.org/2001/XMLSchema-instance"
      xsi:schemaLocation=3D"http://www.kde.org/standards/kcfg/1.0
      http://www.kde.org/standards/kcfg/1.0/kcfg.xsd" >

will become this,
<kcfg xmlns:xsi=3D"http://www.w3.org/2001/XMLSchema-instance" =
xmlns=3D"http://www.kde.org/standards/kcfg/1.0" xsi:schemaLocatio=
n=3D"http://www.kde.org/standards/kcfg/1.0&#xa;      http://www.kd=
e.org/standards/kcfg/1.0/kcfg.xsd">

the issue is in the newline, by removing by hand with $EDITOR fixes the iss=
ue.

Testing <= /h1> 
In the attached image I have modified the main.xml of dictio=
nary and it works.

Diffs=

  • plasmate/editors/kconfigxt/kconfigxteditor.h (e6cd65e)
  • plasmate/editors/kconfigxt/kconfigxteditor.cpp (6f585fc)
  • plasmate/editors/kconfigxt/kconfigxtreader.h (8e923e9)
  • plasmate/editors/kconfigxt/kconfigxtreader.cpp (21ce6ea)
  • plasmate/editors/kconfigxt/kconfigxtwriter.h (d3560cd)
  • plasmate/editors/kconfigxt/kconfigxtwriter.cpp (20d6459)
  • plasmate/mainwindow.cpp (ee2666f)

View Diff
--===============8422176228281852625==-- --===============7517021497364832356== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7517021497364832356==--