'Re: Review Request: remove duplication of code in jade files'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: remove duplication of code in jade files
From:       "Commit Hook" <null () kde ! org>
Date:       2012-12-19 13:39:51
Message-ID: 20121219133951.5202.24561 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107697/#review23721
-----------------------------------------------------------

This review has been submitted with commit d8dae4cce736d239c2ea7bd42fde32cc=
42c0cc73 by Giorgos Tsiapaliokas to branch master.

- Commit Hook

On Dec. 13, 2012, 11:15 a.m., Giorgos Tsiapaliokas wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107697/
> -----------------------------------------------------------
> =

> (Updated Dec. 13, 2012, 11:15 a.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Description
> -------
> =

> This patch changes the structure of the jade files which extend the layou=
t.jade in order
> to avoid duplication of code
> =

> =

> Diffs
> -----
> =

>   server/views/passwordreset.jade f70b889 =

>   server/views/registrationconfirmation.jade a3c4e7c =

> =

> Diff: http://git.reviewboard.kde.org/r/107697/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Giorgos Tsiapaliokas
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107697/">http://git.reviewboard.kde.org/r/107697/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit d8dae4cce736d239c2ea7bd42fde32cc42c0cc73 by Giorgos \
Tsiapaliokas to branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On December 13th, 2012, 11:15 a.m., Giorgos Tsiapaliokas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated Dec. 13, 2012, 11:15 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch changes the structure of the jade files which extend the \
layout.jade in order to avoid duplication of code</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>server/views/passwordreset.jade <span style="color: grey">(f70b889)</span></li>

 <li>server/views/registrationconfirmation.jade <span style="color: \
grey">(a3c4e7c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107697/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 