'Re: Review Request: Pass inhibition on to powerdevil PolicyAgent'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Pass inhibition on to powerdevil PolicyAgent
From:       "Commit Hook" <null () kde ! org>
Date:       2012-12-17 23:13:53
Message-ID: 20121217231353.24041.35625 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107701/#review23645
-----------------------------------------------------------

This review has been submitted with commit fa6d2e86451350730f2bc4c7ba8c7971=
7865b75d by Oliver Henshaw to branch master.

- Commit Hook

On Dec. 13, 2012, 2:05 p.m., Oliver Henshaw wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107701/
> -----------------------------------------------------------
> =

> (Updated Dec. 13, 2012, 2:05 p.m.)
> =

> =

> Review request for Plasma and Solid.
> =

> =

> Description
> -------
> =

> Pass inhibition on to powerdevil PolicyAgent
> =

> So that ScreenSaver inhibit causes ChangeScreenSettings (and thus
> InterruptSession) inhibit.
> =

> =

> Diffs
> -----
> =

>   ksmserver/screenlocker/CMakeLists.txt 0ea6efaa41d5e5a50932af20e7b5f9ef8=
91a41fb =

>   ksmserver/screenlocker/interface.h 689cd4f0edb5275ebce1484a299a8e50e1b2=
8171 =

>   ksmserver/screenlocker/interface.cpp c7678f261055ea3ef5844e77e3502ee360=
451216 =

> =

> Diff: http://git.reviewboard.kde.org/r/107701/diff/
> =

> =

> Testing
> -------
> =

> Tested dbus inhibition via python script and Solid::PowerManagement API u=
se via battery applet. Tested that nothing breaks when powerdevil kded modu=
le is not started or when the kded module is stopped (the PolicyAgent dbus =
service remains available in the latter case).
> =

> =

> Thanks,
> =

> Oliver Henshaw
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107701/">http://git.reviewboard.kde.org/r/107701/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit fa6d2e86451350730f2bc4c7ba8c79717865b75d by Oliver Henshaw to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On December 13th, 2012, 2:05 p.m., Oliver Henshaw wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Solid.</div>
<div>By Oliver Henshaw.</div>

<p style="color: grey;"><i>Updated Dec. 13, 2012, 2:05 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Pass inhibition on to powerdevil PolicyAgent

So that ScreenSaver inhibit causes ChangeScreenSettings (and thus
InterruptSession) inhibit.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested dbus inhibition via python script and Solid::PowerManagement API \
use via battery applet. Tested that nothing breaks when powerdevil kded module is not \
started or when the kded module is stopped (the PolicyAgent dbus service remains \
available in the latter case).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/screenlocker/CMakeLists.txt <span style="color: \
grey">(0ea6efaa41d5e5a50932af20e7b5f9ef891a41fb)</span></li>

 <li>ksmserver/screenlocker/interface.h <span style="color: \
grey">(689cd4f0edb5275ebce1484a299a8e50e1b28171)</span></li>

 <li>ksmserver/screenlocker/interface.cpp <span style="color: \
grey">(c7678f261055ea3ef5844e77e3502ee360451216)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107701/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 