--===============1134226982111383890== Content-Type: multipart/alternative; boundary="===============3884454991345284808==" --===============3884454991345284808== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107702/#review23601 ----------------------------------------------------------- This review has been submitted with commit 78cfd7a02fe4e260c5b09e8e055325e4= 803131bf by Harald Sitter to branch master. - Commit Hook On Dec. 17, 2012, 12:42 p.m., Harald Sitter wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107702/ > ----------------------------------------------------------- > = > (Updated Dec. 17, 2012, 12:42 p.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > KSNI: fix IconThemePath support > = > IconThemePath is used by a Canonical Patch to enable all Qt apps using > QSystemTrayIcon to transparently provide a SNI with icons exported into > a temporary path. Hence the lack of support breaks icons for all Qt apps > on Ubuntu. > = > Fix: > - in the dataengine export IconThemePath > - in the systray protocol pick up the value and forward to QML > - in QML set the themePath accordingly on the IconItem > (requires changes in runtime) > = > https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1088772 > BUG: 311555 > CCMAIL: 1088772@bugs.launchpad.net > REVIEW: 107702 > = > = > This addresses bug 311555. > http://bugs.kde.org/show_bug.cgi?id=3D311555 > = > = > Diffs > ----- > = > plasma/generic/applets/systemtray/package/contents/ui/StatusNotifierIte= m.qml d286c2d727b53febb704d01371974fcfcc0dd10f = > plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtr= aytask.h 127b301fee5357f4080e0ca9fc867df8af746146 = > plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtr= aytask.cpp 63642727630d721fa10151507004eba516715507 = > plasma/generic/dataengines/statusnotifieritem/statusnotifieritemsource.= cpp 61d85f83e250eb3922a7d8a9efad106725fbca99 = > = > Diff: http://git.reviewboard.kde.org/r/107702/diff/ > = > = > Testing > ------- > = > regular KSNI: works (juk, kmix, klipper..) > QSTI providing SNI via sni-qt: works (mumble) > QSTI using xembed: works (mumble) > = > = > Thanks, > = > Harald Sitter > = > --===============3884454991345284808== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107702/ |
This revie= w has been submitted with commit 78cfd7a02fe4e260c5b09e8e055325e4803131bf b= y Harald Sitter to branch master.
- Commit
On December 17th, 2012, 12:42 p.m., Harald Sitter wrote:
Review request for Plasma.
By Harald Sitter.
Updated Dec. 17, 2012, 12:42 p.m. Descripti= on
Testing <= /h1>
Bugs:
311555
Diffs=
|