[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: KSNI: fix IconThemePath support
From: "Marco Martin" <notmart () gmail ! com>
Date: 2012-12-17 12:48:08
Message-ID: 20121217124808.16765.24974 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107702/#review23596
-----------------------------------------------------------
Ship it!
yep, i think this way is pretty good.
i think some creation/destructions of the svg icon could be avoided still, but is a \
minor nitpick
plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp
<http://git.reviewboard.kde.org/r/107702/#comment18099>
maybe if not static m_svgIcon can be something created once on demand then \
reused? any ways is fine tough
- Marco Martin
On Dec. 17, 2012, 12:42 p.m., Harald Sitter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107702/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2012, 12:42 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> KSNI: fix IconThemePath support
>
> IconThemePath is used by a Canonical Patch to enable all Qt apps using
> QSystemTrayIcon to transparently provide a SNI with icons exported into
> a temporary path. Hence the lack of support breaks icons for all Qt apps
> on Ubuntu.
>
> Fix:
> - in the dataengine export IconThemePath
> - in the systray protocol pick up the value and forward to QML
> - in QML set the themePath accordingly on the IconItem
> (requires changes in runtime)
>
> https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1088772
> BUG: 311555
> CCMAIL: 1088772@bugs.launchpad.net
> REVIEW: 107702
>
>
> This addresses bug 311555.
> http://bugs.kde.org/show_bug.cgi?id=311555
>
>
> Diffs
> -----
>
> plasma/generic/applets/systemtray/package/contents/ui/StatusNotifierItem.qml \
> d286c2d727b53febb704d01371974fcfcc0dd10f \
> plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.h \
> 127b301fee5357f4080e0ca9fc867df8af746146 \
> plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp \
> 63642727630d721fa10151507004eba516715507 \
> plasma/generic/dataengines/statusnotifieritem/statusnotifieritemsource.cpp \
> 61d85f83e250eb3922a7d8a9efad106725fbca99
> Diff: http://git.reviewboard.kde.org/r/107702/diff/
>
>
> Testing
> -------
>
> regular KSNI: works (juk, kmix, klipper..)
> QSTI providing SNI via sni-qt: works (mumble)
> QSTI using xembed: works (mumble)
>
>
> Thanks,
>
> Harald Sitter
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107702/">http://git.reviewboard.kde.org/r/107702/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yep, i think this way is \
pretty good. i think some creation/destructions of the svg icon could be avoided \
still, but is a minor nitpick</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/107702/diff/2/?file=99912#file99912line131" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">bool static hasm_svgIcon(QVariant source)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">131</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QScopedPointer</span><span class="o"><</span><span \
class="n">Plasma</span><span class="o">::</span><span class="n">Svg</span><span \
class="o">></span> <span class="n">m_svgIcon</span><span class="p">(</span><span \
class="k">new</span> <span class="n">Plasma</span><span class="o">::</span><span \
class="n">Svg</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">maybe if \
not static m_svgIcon can be something created once on demand then reused? any ways is \
fine tough</pre> </div>
<br />
<p>- Marco</p>
<br />
<p>On December 17th, 2012, 12:42 p.m., Harald Sitter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated Dec. 17, 2012, 12:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KSNI: fix IconThemePath support
IconThemePath is used by a Canonical Patch to enable all Qt apps using
QSystemTrayIcon to transparently provide a SNI with icons exported into
a temporary path. Hence the lack of support breaks icons for all Qt apps
on Ubuntu.
Fix:
- in the dataengine export IconThemePath
- in the systray protocol pick up the value and forward to QML
- in QML set the themePath accordingly on the IconItem
(requires changes in runtime)
https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1088772
BUG: 311555
CCMAIL: 1088772@bugs.launchpad.net
REVIEW: 107702</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">regular KSNI: works (juk, kmix, klipper..) QSTI providing SNI via \
sni-qt: works (mumble) QSTI using xembed: works (mumble)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=311555">311555</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/systemtray/package/contents/ui/StatusNotifierItem.qml \
<span style="color: grey">(d286c2d727b53febb704d01371974fcfcc0dd10f)</span></li>
<li>plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.h \
<span style="color: grey">(127b301fee5357f4080e0ca9fc867df8af746146)</span></li>
<li>plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp \
<span style="color: grey">(63642727630d721fa10151507004eba516715507)</span></li>
<li>plasma/generic/dataengines/statusnotifieritem/statusnotifieritemsource.cpp <span \
style="color: grey">(61d85f83e250eb3922a7d8a9efad106725fbca99)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107702/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic