'Re: Review Request: show notification summary for last popup notification'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: show notification summary for last popup notification
From:       "Xuetian Weng" <wengxt () gmail ! com>
Date:       2012-12-16 23:17:47
Message-ID: 20121216231747.4910.35222 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107743/
-----------------------------------------------------------

(Updated Dec. 16, 2012, 11:17 p.m.)

Review request for Plasma and Marco Martin.

Changes
-------

I think I found why it's not bold.. PlasmaComponenets.Label is a QML Text, and weight \
is already bind with default.themeFont.weight, and bold is just kinds of alias to set \
Bold. so it's not working. This update fixes them all. Now bold work, and it will not \
take space if summary is empty.

Description
-------

New qml notification doesn't show summary for last popup notification. This patch add \
summary back.

This addresses bug 307670.
    http://bugs.kde.org/show_bug.cgi?id=307670

Diffs (updated)
-----

  plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml e63526b 
  plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml \
9e4345a 

Diff: http://git.reviewboard.kde.org/r/107743/diff/

Testing
-------

No problem here. Looks ok.

Screenshots
-----------

current appearance
  http://git.reviewboard.kde.org/r/107743/s/899/

Thanks,

Xuetian Weng

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107743/">http://git.reviewboard.kde.org/r/107743/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Xuetian Weng.</div>

<p style="color: grey;"><i>Updated Dec. 16, 2012, 11:17 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I think I found why it&#39;s not bold.. PlasmaComponenets.Label is a QML \
Text, and weight is already bind with default.themeFont.weight, and bold is just \
kinds of alias to set Bold. so it&#39;s not working. This update fixes them all. Now \
bold work, and it will not take space if summary is empty.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">New qml notification doesn&#39;t show summary for last popup \
notification. This patch add summary back.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No problem here. Looks ok.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=307670">307670</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml <span \
style="color: grey">(e63526b)</span></li>

 <li>plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml \
<span style="color: grey">(9e4345a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107743/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/107743/s/899/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/15/plasma-desktopKK1200_400x100.png" \
style="border: 1px black solid;" alt="current appearance" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 