[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Change Battery Percentage step of battery plasmoid
From: "Commit Hook" <null () kde ! org>
Date: 2012-12-14 23:59:29
Message-ID: 20121214235929.14956.97935 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107612/#review23495
-----------------------------------------------------------
This review has been submitted with commit 0d1ac2a4c98aa739a9b219370e0cd85d=
2072b65d by Weng Xuetian to branch master.
- Commit Hook
On Dec. 6, 2012, 7:04 p.m., Xuetian Weng wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107612/
> -----------------------------------------------------------
> =
> (Updated Dec. 6, 2012, 7:04 p.m.)
> =
> =
> Review request for Plasma, Marco Martin and Viranch Mehta.
> =
> =
> Description
> -------
> =
> Current battery plasmoid icon is very confusing when showing the percenta=
ge.
> =
> Currently,
> 96-100 -> looks like 100
> 81-95->looks like 80 (looks werid)
> 50-80->looks like 60 (looks werid)
> 20->49->looks like 40
> 10->19->looks like 20
> =
> When people see the icon shows as 60, they will expect that whey have los=
t nearly 40 percent, but actually 70-80 is also covered in this range.
> =
> And range doesn't split evenly is also a problem.
> This patch change it to
> 90-100 looks like 100
> 70-89 looks like 80
> 50-69 looks like 60
> 30-49 looks like 40
> 10-29 looks like 20
> =
> Which IMHO is much better for visual.
> =
> =
> Diffs
> -----
> =
> plasma/generic/applets/batterymonitor/contents/ui/BatteryIcon.qml cfb50=
df =
> =
> Diff: http://git.reviewboard.kde.org/r/107612/diff/
> =
> =
> Testing
> -------
> =
> No problem.
> =
> =
> Thanks,
> =
> Xuetian Weng
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107612/">http://git.reviewboard.kde.org/r/107612/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 0d1ac2a4c98aa739a9b219370e0cd85d2072b65d by Weng Xuetian to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On December 6th, 2012, 7:04 p.m., Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Marco Martin and Viranch Mehta.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Dec. 6, 2012, 7:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Current battery plasmoid icon is very confusing when showing the \
percentage.
Currently,
96-100 -> looks like 100
81-95->looks like 80 (looks werid)
50-80->looks like 60 (looks werid)
20->49->looks like 40
10->19->looks like 20
When people see the icon shows as 60, they will expect that whey have lost nearly 40 \
percent, but actually 70-80 is also covered in this range.
And range doesn't split evenly is also a problem.
This patch change it to
90-100 looks like 100
70-89 looks like 80
50-69 looks like 60
30-49 looks like 40
10-29 looks like 20
Which IMHO is much better for visual.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No problem.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/batterymonitor/contents/ui/BatteryIcon.qml <span \
style="color: grey">(cfb50df)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107612/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic