'Review Request: KSNI: fix IconThemePath support'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: KSNI: fix IconThemePath support
From:       "Harald Sitter" <sitter () kde ! org>
Date:       2012-12-13 14:19:50
Message-ID: 20121213141950.26561.13202 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107702/
-----------------------------------------------------------

Review request for Plasma.

Description
-------

Also see https://git.reviewboard.kde.org/r/107703/

KSNI: fix IconThemePath support

IconThemePath is used by a Canonical Patch to enable all Qt apps using
QSystemTrayIcon to transparently provide a SNI with icons exported into
a temporary path. Hence the lack of support breaks icons for all Qt apps
on Ubuntu.

Fix:
- in the dataengine export IconThemePath
- in the systray protocol pick up the value and forward to QML
- in QML set the themePath accordingly on the IconItem
  (requires changes in runtime)

https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1088772
BUG: 311555
CCMAIL: 1088772@bugs.launchpad.net

This addresses bug 311555.
    http://bugs.kde.org/show_bug.cgi?id=311555

Diffs
-----

  plasma/generic/applets/systemtray/package/contents/ui/StatusNotifierItem.qml \
d286c2d727b53febb704d01371974fcfcc0dd10f   \
plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.h \
127b301fee5357f4080e0ca9fc867df8af746146   \
plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp \
63642727630d721fa10151507004eba516715507   \
plasma/generic/dataengines/statusnotifieritem/statusnotifieritemsource.cpp \
61d85f83e250eb3922a7d8a9efad106725fbca99 

Diff: http://git.reviewboard.kde.org/r/107702/diff/

Testing
-------

regular KSNI: works (juk, kmix, klipper..)
QSTI providing SNI via sni-qt: works (mumble)
QSTI using xembed: works (mumble)

Thanks,

Harald Sitter

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107702/">http://git.reviewboard.kde.org/r/107702/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Harald Sitter.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Also see https://git.reviewboard.kde.org/r/107703/

KSNI: fix IconThemePath support

IconThemePath is used by a Canonical Patch to enable all Qt apps using
QSystemTrayIcon to transparently provide a SNI with icons exported into
a temporary path. Hence the lack of support breaks icons for all Qt apps
on Ubuntu.

Fix:
- in the dataengine export IconThemePath
- in the systray protocol pick up the value and forward to QML
- in QML set the themePath accordingly on the IconItem
  (requires changes in runtime)

https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1088772
BUG: 311555
CCMAIL: 1088772@bugs.launchpad.net</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">regular KSNI: works (juk, kmix, klipper..) QSTI providing SNI via \
sni-qt: works (mumble) QSTI using xembed: works (mumble)</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=311555">311555</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/systemtray/package/contents/ui/StatusNotifierItem.qml \
<span style="color: grey">(d286c2d727b53febb704d01371974fcfcc0dd10f)</span></li>

 <li>plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.h \
<span style="color: grey">(127b301fee5357f4080e0ca9fc867df8af746146)</span></li>

 <li>plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp \
<span style="color: grey">(63642727630d721fa10151507004eba516715507)</span></li>

 <li>plasma/generic/dataengines/statusnotifieritem/statusnotifieritemsource.cpp <span \
style="color: grey">(61d85f83e250eb3922a7d8a9efad106725fbca99)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107702/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 