From kde-panel-devel Fri Nov 30 12:39:24 2012 From: "Commit Hook" Date: Fri, 30 Nov 2012 12:39:24 +0000 To: kde-panel-devel Subject: Re: Review Request: fixed comic tooltip and buttons bar display Message-Id: <20121130123924.30981.11582 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=135427919803235 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3114122786328120701==" --===============3114122786328120701== Content-Type: multipart/alternative; boundary="===============3591579028692435418==" --===============3591579028692435418== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107444/#review22813 ----------------------------------------------------------- This review has been submitted with commit 4d531d4104be0c72db2bd1f41a20a249= e6a3fbc3 by Reza Shah to branch master. - Commit Hook On Nov. 24, 2012, 1:33 p.m., Reza Shah wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107444/ > ----------------------------------------------------------- > = > (Updated Nov. 24, 2012, 1:33 p.m.) > = > = > Review request for Plasma and Marco Martin. > = > = > Description > ------- > = > In current codes the tooltip target is not set because it will blocked th= e buttons bar visibility on mouse hover. > This patch tries to fix that problem. > = > = > Diffs > ----- > = > applets/comic/package/contents/ui/ComicCentralView.qml 33fc886 = > applets/comic/package/contents/ui/ImageWidget.qml 56bcc0b = > = > Diff: http://git.reviewboard.kde.org/r/107444/diff/ > = > = > Testing > ------- > = > Tested against master. = > Tooltip and buttons bar both can be displayed together now. > = > = > Thanks, > = > Reza Shah > = > --===============3591579028692435418== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107444/ 

This revie=
w has been submitted with commit 4d531d4104be0c72db2bd1f41a20a249e6a3fbc3 b=
y Reza Shah to branch master.

- Commit


On November 24th, 2012, 1:33 p.m., Reza Shah wrote:

Review request for Plasma and Marco Martin.
By Reza Shah.

Updated Nov. 24, 2012, 1:33 p.m.

Descripti= on 

In current codes the tooltip target is not set because it wi=
ll blocked the buttons bar visibility on mouse hover.
This patch tries to fix that problem.

Testing <= /h1> 
Tested against master. =

Tooltip and buttons bar both can be displayed together now.

Diffs=

  • applets/comic/package/contents/ui/ComicCentralView.qml (33fc886)
  • applets/comic/package/contents/ui/ImageWidget.qml (56bcc0b)

View Diff
--===============3591579028692435418==-- --===============3114122786328120701== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============3114122786328120701==--