'Re: Review Request: Save and restore position of widgets in vertically-oriented FlowGroup'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Save and restore position of widgets in vertically-oriented FlowGroup
From:       "Commit Hook" <null () kde ! org>
Date:       2012-11-29 12:07:57
Message-ID: 20121129120757.17254.96240 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107477/#review22751
-----------------------------------------------------------

This review has been submitted with commit 34bca25fdcdcec4b9b705c4ae9d798f8dd46f4f8 \
by Dan Vrátil to branch KDE/4.9.

- Commit Hook

On Nov. 26, 2012, 4:56 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107477/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2012, 4:56 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This fixes a bug when widgets were all stacked at (0,0) in a vertically-oriented \
> Grouping Panel after plasma restart 
> Downstream bug report: https://bugzilla.redhat.com/show_bug.cgi?id=879802
> 
> 
> Diffs
> -----
> 
> containments/groupingdesktop/lib/groups/flowgroup.cpp d330679 
> 
> Diff: http://git.reviewboard.kde.org/r/107477/diff/
> 
> 
> Testing
> -------
> 
> Created a vertical Grouping Panel, placed a widget into middle, restarted plasma, \
> widget position is correctly restored. 
> 
> Thanks,
> 
> Dan Vrátil
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107477/">http://git.reviewboard.kde.org/r/107477/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 34bca25fdcdcec4b9b705c4ae9d798f8dd46f4f8 by Dan Vrátil to \
branch KDE/4.9.</pre>  <br />

<p>- Commit</p>

<br />
<p>On November 26th, 2012, 4:56 p.m., Dan Vrátil wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Dan Vrátil.</div>

<p style="color: grey;"><i>Updated Nov. 26, 2012, 4:56 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This fixes a bug when widgets were all stacked at (0,0) in a \
vertically-oriented Grouping Panel after plasma restart

Downstream bug report: https://bugzilla.redhat.com/show_bug.cgi?id=879802</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Created a vertical Grouping Panel, placed a widget into middle, \
restarted plasma, widget position is correctly restored.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>containments/groupingdesktop/lib/groups/flowgroup.cpp <span style="color: \
grey">(d330679)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107477/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 