[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate: on SigningDialog::validateParams() replace QRegExp with KPIMUtils::isV
From: "Giorgos Tsiapaliokas" <terietor () gmail ! com>
Date: 2012-11-26 14:33:16
Message-ID: 20121126143316.19857.24391 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 26, 2012, 1:43 p.m., Diego Casella wrote:
> > plasmate/CMakeLists.txt, line 102
> > <http://git.reviewboard.kde.org/r/107470/diff/1/?file=96184#file96184line102>
> >
> > I'm wondering if we really need to add a kdepimutils dependency for a simple \
> > email validation... Thoughts about that?
> > In any case, "kpimutils" must be discarded and substituted with the more portable \
> > ${KDEPIMLIBS_KPIMUTILS_LIBS} (more info inside FindKdepimLibs.cmake file).
> I'm wondering if we really need to add a kdepimutils dependency for a simple email \
> validation... Thoughts about that?
Plasmate already depends on qgpgme++ library which is in kdepimlibs. Kdepimutils are \
also part of the kdepimlibs. So we don't introduce a new depedency for a new \
repository.
Also we have been advised for this change from the kdereview.
- Giorgos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107470/#review22561
-----------------------------------------------------------
On Nov. 26, 2012, 10:36 a.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107470/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2012, 10:36 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> On this patch i am replace the QRegExp on SigningDialog::validateParams() with \
> KPIMUtils::isValidSimpleAddress
>
> Diffs
> -----
>
> plasmate/CMakeLists.txt 111c402
> plasmate/publisher/signingdialog.cpp 395138d
>
> Diff: http://git.reviewboard.kde.org/r/107470/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107470/">http://git.reviewboard.kde.org/r/107470/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 26th, 2012, 1:43 p.m., <b>Diego \
Casella</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/107470/diff/1/?file=96184#file96184line102" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmate/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">102</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
kpimutils</pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm wondering if we \
really need to add a kdepimutils dependency for a simple email validation... Thoughts \
about that?
In any case, "kpimutils" must be discarded and substituted with the more \
portable ${KDEPIMLIBS_KPIMUTILS_LIBS} (more info inside FindKdepimLibs.cmake \
file).</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">>I'm \
wondering if we really need to add a kdepimutils dependency for a simple email \
validation... Thoughts about that? Plasmate already depends on qgpgme++ library which \
is in kdepimlibs. Kdepimutils are also part of the kdepimlibs. So we don't \
introduce a new depedency for a new repository.
Also we have been advised for this change from the kdereview.</pre>
<br />
<p>- Giorgos</p>
<br />
<p>On November 26th, 2012, 10:36 a.m., Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Nov. 26, 2012, 10:36 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">On this patch i am replace the QRegExp on \
SigningDialog::validateParams() with KPIMUtils::isValidSimpleAddress</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/CMakeLists.txt <span style="color: grey">(111c402)</span></li>
<li>plasmate/publisher/signingdialog.cpp <span style="color: \
grey">(395138d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107470/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic