From kde-panel-devel Sat Nov 24 15:06:39 2012 From: "Commit Hook" Date: Sat, 24 Nov 2012 15:06:39 +0000 To: kde-panel-devel Subject: Re: Review Request: [High-dpi issues] Fix panelcontroller Screen Edge/Height icons fixed size Message-Id: <20121124150639.4374.44457 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=135376961402871 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4534226044485085664==" --===============4534226044485085664== Content-Type: multipart/alternative; boundary="===============2733303789031303059==" --===============2733303789031303059== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107414/#review22483 ----------------------------------------------------------- This review has been submitted with commit 6e00a82134a33b8cdaad1d29543fc6c8= 6e1d743d by Kai Uwe Broulik to branch KDE/4.9. - Commit Hook On Nov. 22, 2012, 9:16 a.m., Kai Uwe Broulik wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107414/ > ----------------------------------------------------------- > = > (Updated Nov. 22, 2012, 9:16 a.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > The svg is scaled using KIconLoader::StdSizes instead of using IconSize(K= IconLoader::Group) making the icon size hardcoded. > = > Thanks for Mzanetti for adding this little thing to the list of high-dpi = issues :) > = > = > Diffs > ----- > = > plasma/desktop/shell/panelcontroller.cpp e668e7b = > = > Diff: http://git.reviewboard.kde.org/r/107414/diff/ > = > = > Testing > ------- > = > Tested with various small icon sizes and works flawlessly even with 48px = icons. > = > = > Thanks, > = > Kai Uwe Broulik > = > --===============2733303789031303059== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107414/ 

This revie=
w has been submitted with commit 6e00a82134a33b8cdaad1d29543fc6c86e1d743d b=
y Kai Uwe Broulik to branch KDE/4.9.

- Commit


On November 22nd, 2012, 9:16 a.m., Kai Uwe Broulik wrote:

Review request for Plasma.
By Kai Uwe Broulik.

Updated Nov. 22, 2012, 9:16 a.m.

Descripti= on 

The svg is scaled using KIconLoader::StdSizes instead of usi=
ng IconSize(KIconLoader::Group) making the icon size hardcoded.

Thanks for Mzanetti for adding this little thing to the list of high-dpi is=
sues :)

Testing <= /h1> 
Tested with various small icon sizes and works flawlessly ev=
en with 48px icons.

Diffs=

  • plasma/desktop/shell/panelcontroller.cpp (= e668e7b)

View Diff
--===============2733303789031303059==-- --===============4534226044485085664== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4534226044485085664==--