'Re: Review Request: plasmoid currentappconrol - max width of dropdown'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: plasmoid currentappconrol - max width of dropdown
From:       "Commit Hook" <null () kde ! org>
Date:       2012-11-23 21:18:18
Message-ID: 20121123211818.11046.55392 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107433/#review22448
-----------------------------------------------------------

This review has been submitted with commit 67fd7396facad9a282ecaed0d9600f5a=
b4daead6 by Gregor T=C3=A4tzner to branch master.

- Commit Hook

On Nov. 23, 2012, 10:27 a.m., Greg T wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107433/
> -----------------------------------------------------------
> =

> (Updated Nov. 23, 2012, 10:27 a.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Description
> -------
> =

> the drop down list gets too wide (see screenshot), when the window titles=
 are too long or the horizontal space is very small.
> In the patch I've elided the text width to ~80% of the screen width. Or i=
s there a more natural solution?
> =

> =

> Diffs
> -----
> =

>   plasma/netbook/applets/currentappcontrol/currentappcontrol.cpp 5c2e73f9=
d6b8207efd3a3de6464278d1bdbc9263 =

> =

> Diff: http://git.reviewboard.kde.org/r/107433/diff/
> =

> =

> Testing
> -------
> =

> =

> Screenshots
> -----------
> =

> dropdown
>   http://git.reviewboard.kde.org/r/107433/s/850/
> =

> =

> Thanks,
> =

> Greg T
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107433/">http://git.reviewboard.kde.org/r/107433/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 67fd7396facad9a282ecaed0d9600f5ab4daead6 by Gregor Tätzner to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On November 23rd, 2012, 10:27 a.m., Greg T wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Greg T.</div>

<p style="color: grey;"><i>Updated Nov. 23, 2012, 10:27 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">the drop down list gets too wide (see screenshot), when the window \
titles are too long or the horizontal space is very small. In the patch I&#39;ve \
elided the text width to ~80% of the screen width. Or is there a more natural \
solution?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/netbook/applets/currentappcontrol/currentappcontrol.cpp <span \
style="color: grey">(5c2e73f9d6b8207efd3a3de6464278d1bdbc9263)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107433/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/107433/s/850/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/23/dropdown-cac_400x100.jpeg" \
style="border: 1px black solid;" alt="dropdown" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 