[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens
From: "Michael Zanetti" <mzanetti () kde ! org>
Date: 2012-11-23 18:21:54
Message-ID: 20121123182154.11294.87218 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 23, 2012, 1:03 p.m., Kai Uwe Broulik wrote:
> > plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml, line \
> > 129 <http://git.reviewboard.kde.org/r/107428/diff/1/?file=95873#file95873line129>
> >
> > Do two lines fit in? Maybe use
> > elide: Text.ElideRight
> > MaximumLineCount: 2
>
> Michael Zanetti wrote:
> If I'm not completely blind the Plasma.Label does not support eliding, thats why I \
> clipped instead.
> No, how it is currently, 2 lines would trash the layout as the icons size is tied \
> to the text height. I couldn't find anything reasonable to get a dynamic size but \
> still having it looking the same it did before.
ok... no clue in what docs I ended up yesterday... Anyways, I'll try to restore the \
wordwrap somehow before eliding...
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107428/#review22425
-----------------------------------------------------------
On Nov. 23, 2012, 6:15 p.m., Michael Zanetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107428/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2012, 6:15 p.m.)
>
>
> Review request for Plasma and Kai Uwe Broulik.
>
>
> Description
> -------
>
> This adjustst the DeviceNotifier Plasmoid to scale nicely with high resolution \
> screens.
> The patch changes also one label from wordWrapping to clipping behavior because \
> otherwise it messes up the layout.
>
> Diffs
> -----
>
> plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml 1fab0ef
> plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml \
> f8728d0
> Diff: http://git.reviewboard.kde.org/r/107428/diff/
>
>
> Testing
> -------
>
> Tested on High res screen at full DPI and at regular DPI values
>
>
> Thanks,
>
> Michael Zanetti
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107428/">http://git.reviewboard.kde.org/r/107428/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 23rd, 2012, 1:03 p.m., <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/107428/diff/1/?file=95873#file95873line129" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">129</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="hl">wrapMode: Text.WordWrap</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">129</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="hl">clip: true</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do two lines fit in? \
Maybe use
elide: Text.ElideRight
MaximumLineCount: 2</pre>
</blockquote>
<p>On November 23rd, 2012, 6:15 p.m., <b>Michael Zanetti</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If I'm not \
completely blind the Plasma.Label does not support eliding, thats why I clipped \
instead.
No, how it is currently, 2 lines would trash the layout as the icons size is tied to \
the text height. I couldn't find anything reasonable to get a dynamic size but \
still having it looking the same it did before.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ok... no \
clue in what docs I ended up yesterday... Anyways, I'll try to restore the \
wordwrap somehow before eliding...</pre> <br />
<p>- Michael</p>
<br />
<p>On November 23rd, 2012, 6:15 p.m., Michael Zanetti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Kai Uwe Broulik.</div>
<div>By Michael Zanetti.</div>
<p style="color: grey;"><i>Updated Nov. 23, 2012, 6:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This adjustst the DeviceNotifier Plasmoid to scale nicely with high \
resolution screens.
The patch changes also one label from wordWrapping to clipping behavior because \
otherwise it messes up the layout.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on High res screen at full DPI and at regular DPI values</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml <span \
style="color: grey">(1fab0ef)</span></li>
<li>plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml \
<span style="color: grey">(f8728d0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107428/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic