'Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens
From:       "Michael Zanetti" <mzanetti () kde ! org>
Date:       2012-11-23 18:15:34
Message-ID: 20121123181534.8368.35258 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107428/
-----------------------------------------------------------

(Updated Nov. 23, 2012, 6:15 p.m.)

Review request for Plasma and Kai Uwe Broulik.

Description
-------

This adjustst the DeviceNotifier Plasmoid to scale nicely with high resolut=
ion screens.

The patch changes also one label from wordWrapping to clipping behavior bec=
ause otherwise it messes up the layout.

Diffs
-----

  plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml =
1fab0ef =

  plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.=
qml f8728d0 =

Diff: http://git.reviewboard.kde.org/r/107428/diff/

Testing
-------

Tested on High res screen at full DPI and at regular DPI values

Thanks,

Michael Zanetti

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107428/">http://git.reviewboard.kde.org/r/107428/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Kai Uwe Broulik.</div>
<div>By Michael Zanetti.</div>

<p style="color: grey;"><i>Updated Nov. 23, 2012, 6:15 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This adjustst the DeviceNotifier Plasmoid to scale nicely with high \
resolution screens.

The patch changes also one label from wordWrapping to clipping behavior because \
otherwise it messes up the layout.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on High res screen at full DPI and at regular DPI values</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml <span \
style="color: grey">(1fab0ef)</span></li>

 <li>plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml \
<span style="color: grey">(f8728d0)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107428/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 