'Re: Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage
From:       "Commit Hook" <null () kde ! org>
Date:       2012-11-23 11:55:47
Message-ID: 20121123115547.28688.1798 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107413/#review22421
-----------------------------------------------------------

This review has been submitted with commit 4769d2f180add18190fb5585e333e3bdca7752b4 \
by Jan Grulich to branch KDE/4.9.

- Commit Hook

On Nov. 23, 2012, 11:12 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107413/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2012, 11:12 a.m.)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Description
> -------
> 
> Switch from QWeakPointer to staticaly created KNS3::DownloadDialog like in some \
> KControl modules (i.e color scheme) to fix the problem when the list with widgets \
> is not downloaded every time you open it. Should fix this issue \
> https://bugzilla.redhat.com/show_bug.cgi?id=877021 
> 
> Diffs
> -----
> 
> plasma/private/packages.cpp 2519341 
> 
> Diff: http://git.reviewboard.kde.org/r/107413/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107413/">http://git.reviewboard.kde.org/r/107413/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 4769d2f180add18190fb5585e333e3bdca7752b4 by Jan Grulich to \
branch KDE/4.9.</pre>  <br />

<p>- Commit</p>

<br />
<p>On November 23rd, 2012, 11:12 a.m., Jan Grulich wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs and Plasma.</div>
<div>By Jan Grulich.</div>

<p style="color: grey;"><i>Updated Nov. 23, 2012, 11:12 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Switch from QWeakPointer to staticaly created KNS3::DownloadDialog like \
in some KControl modules (i.e color scheme) to fix the problem when the list with \
widgets is not downloaded every time you open it. Should fix this issue \
https://bugzilla.redhat.com/show_bug.cgi?id=877021</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/private/packages.cpp <span style="color: grey">(2519341)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107413/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 