[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate: Fix typo on remoteinstaller.ui and give more sane names to labels.
From: "Commit Hook" <null () kde ! org>
Date: 2012-11-21 22:20:10
Message-ID: 20121121222010.970.31011 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107312/#review22351
-----------------------------------------------------------
This review has been submitted with commit eb93686fcb9b0e1c63563164dbceadd69a2f235f \
by Antonis Tsiapaliokas to branch master.
- Commit Hook
On Nov. 13, 2012, 6:20 p.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107312/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2012, 6:20 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This patch is changing the
>
> "Choose the source directory of your package.Your URL must end in a \
> metadata.desktop file." => "Choose the source directory of your package."
> Because the remoteinstaller doesn't need the metadata.desktop but it needs the \
> directory in which the metadata.dekstop is located.
> Also i have change the names of the labels of the remoteinsteller.ui, in order to \
> be more pretty.
>
> Diffs
> -----
>
> plasmate/publisher/remoteinstaller/remoteinstaller.cpp 68bb7e3
> plasmate/publisher/remoteinstaller/remoteinstaller.ui ba9b0a3
> plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp aed72db
> plasmate/publisher/remoteinstaller/standalone/plasmaremoteinstaller.cpp 68554d4
>
> Diff: http://git.reviewboard.kde.org/r/107312/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107312/">http://git.reviewboard.kde.org/r/107312/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit eb93686fcb9b0e1c63563164dbceadd69a2f235f by Antonis \
Tsiapaliokas to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On November 13th, 2012, 6:20 p.m., Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Nov. 13, 2012, 6:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch is changing the
"Choose the source directory of your package.Your URL must end in a \
metadata.desktop file." => "Choose the source directory of your \
package."
Because the remoteinstaller doesn't need the metadata.desktop but it needs the \
directory in which the metadata.dekstop is located.
Also i have change the names of the labels of the remoteinsteller.ui, in order to be \
more pretty.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/publisher/remoteinstaller/remoteinstaller.cpp <span style="color: \
grey">(68bb7e3)</span></li>
<li>plasmate/publisher/remoteinstaller/remoteinstaller.ui <span style="color: \
grey">(ba9b0a3)</span></li>
<li>plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp <span style="color: \
grey">(aed72db)</span></li>
<li>plasmate/publisher/remoteinstaller/standalone/plasmaremoteinstaller.cpp <span \
style="color: grey">(68554d4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107312/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic