'Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal
From:       Àlex_Fiestas <afiestas () kde ! org>
Date:       2012-11-21 17:35:49
Message-ID: 20121121173549.975.85266 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107398/#review22330
-----------------------------------------------------------

Now that I think about it, ltinkl can review this as well !

- Àlex Fiestas

On Nov. 21, 2012, 5:21 p.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107398/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2012, 5:21 p.m.)
> 
> 
> Review request for Plasma and Dario Freddi.
> 
> 
> Description
> -------
> 
> the upower powerdevilbackend doesnt emit a screenBrightnessChanged signal when you \
> change the brightness without the brightnessKeys. I've just moved the signal to the \
> setBrightness function. Now the powermanagement/PowerDevil dataengine gets also \
> updated properly with the current brightness (this fixes the bugs). 
> 
> This addresses bugs 302111 and 302160.
> http://bugs.kde.org/show_bug.cgi?id=302111
> http://bugs.kde.org/show_bug.cgi?id=302160
> 
> 
> Diffs
> -----
> 
> powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp \
> 3d0926fab8dac334d56d5cce430691e501b6f8c7  
> Diff: http://git.reviewboard.kde.org/r/107398/diff/
> 
> 
> Testing
> -------
> 
> works on my laptop when I set the screen brightness with the batterymonitor \
> plasmoid 
> 
> Thanks,
> 
> Greg T
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107398/">http://git.reviewboard.kde.org/r/107398/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now that I think about \
it, ltinkl can review this as well !</pre>  <br />

<p>- Àlex</p>

<br />
<p>On November 21st, 2012, 5:21 p.m., Greg T wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Dario Freddi.</div>
<div>By Greg T.</div>

<p style="color: grey;"><i>Updated Nov. 21, 2012, 5:21 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">the upower powerdevilbackend doesnt emit a screenBrightnessChanged \
signal when you change the brightness without the brightnessKeys. I&#39;ve just moved \
the signal to the setBrightness function. Now the powermanagement/PowerDevil \
dataengine gets also updated properly with the current brightness (this fixes the \
bugs).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works on my laptop when I set the screen brightness with the \
batterymonitor plasmoid</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=302111">302111</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=302160">302160</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp <span \
style="color: grey">(3d0926fab8dac334d56d5cce430691e501b6f8c7)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107398/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 