[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Reduce runtime warnings
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2012-11-21 9:35:22
Message-ID: 20121121093522.2438.47894 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107379/#review22292
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Nov. 19, 2012, 1:15 p.m., Aleix Pol Gonzalez wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107379/
> -----------------------------------------------------------
> =

> (Updated Nov. 19, 2012, 1:15 p.m.)
> =

> =

> Review request for Plasma and Marco Martin.
> =

> =

> Description
> -------
> =

> When executing muon, I'd get this warning:
> Object::connect: No such signal QDeclarativeItem::minimumWidthChanged() i=
n /home/kde-devel/src/kde-runtime/plasma/declarativeimports/core/declarativ=
eitemcontainer.cpp:61
> Object::connect: No such signal QDeclarativeItem::minimumHeightChanged() =
in /home/kde-devel/src/kde-runtime/plasma/declarativeimports/core/declarati=
veitemcontainer.cpp:62
> Object::connect: No such signal QDeclarativeItem::maximumWidthChanged() i=
n /home/kde-devel/src/kde-runtime/plasma/declarativeimports/core/declarativ=
eitemcontainer.cpp:66
> Object::connect: No such signal QDeclarativeItem::maximumHeightChanged() =
in /home/kde-devel/src/kde-runtime/plasma/declarativeimports/core/declarati=
veitemcontainer.cpp:67
> Object::connect: No such signal QDeclarativeItem::preferredWidthChanged()=
 in /home/kde-devel/src/kde-runtime/plasma/declarativeimports/core/declarat=
iveitemcontainer.cpp:71
> Object::connect: No such signal QDeclarativeItem::preferredHeightChanged(=
) in /home/kde-devel/src/kde-runtime/plasma/declarativeimports/core/declara=
tiveitemcontainer.cpp:72
> =

> This patch solves the problem like I did in kdelibs...
> =

> =

> Diffs
> -----
> =

>   plasma/declarativeimports/core/declarativeitemcontainer.cpp bd55c6a =

> =

> Diff: http://git.reviewboard.kde.org/r/107379/diff/
> =

> =

> Testing
> -------
> =

> Installed and ran again
> =

> =

> Thanks,
> =

> Aleix Pol Gonzalez
> =

>


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107379/">http://git.reviewboard.kde.org/r/107379/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />







<p>- Marco</p>


<br />
<p>On November 19th, 2012, 1:15 p.m., Aleix Pol Gonzalez wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Aleix Pol Gonzalez.</div>


<p style="color: grey;"><i>Updated Nov. 19, 2012, 1:15 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When executing muon, I&#39;d get this warning: Object::connect: No such \
signal QDeclarativeItem::minimumWidthChanged() in \
/home/kde-devel/src/kde-runtime/plasma/declarativeimports/core/declarativeitemcontainer.cpp:61
 Object::connect: No such signal QDeclarativeItem::minimumHeightChanged() in \
/home/kde-devel/src/kde-runtime/plasma/declarativeimports/core/declarativeitemcontainer.cpp:62
 Object::connect: No such signal QDeclarativeItem::maximumWidthChanged() in \
/home/kde-devel/src/kde-runtime/plasma/declarativeimports/core/declarativeitemcontainer.cpp:66
 Object::connect: No such signal QDeclarativeItem::maximumHeightChanged() in \
/home/kde-devel/src/kde-runtime/plasma/declarativeimports/core/declarativeitemcontainer.cpp:67
 Object::connect: No such signal QDeclarativeItem::preferredWidthChanged() in \
/home/kde-devel/src/kde-runtime/plasma/declarativeimports/core/declarativeitemcontainer.cpp:71
 Object::connect: No such signal QDeclarativeItem::preferredHeightChanged() in \
/home/kde-devel/src/kde-runtime/plasma/declarativeimports/core/declarativeitemcontainer.cpp:72


This patch solves the problem like I did in kdelibs...</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Installed and ran again</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/declarativeimports/core/declarativeitemcontainer.cpp <span style="color: \
grey">(bd55c6a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107379/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic