[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Rework of metadatamusic qml components.
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2012-11-13 14:58:01
Message-ID: 20121113145801.22187.50942 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107299/#review21932
-----------------------------------------------------------
i assume someone give this approval on irc so it was committed, but in futu=
re, please have the person who peer reviews the patch mark the review with =
"ShipIt!" so that we know it has actually seen peer review. thanks :)
- Aaron J. Seigo
On Nov. 13, 2012, 11:11 a.m., Fabian Riethmayer wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107299/
> -----------------------------------------------------------
> =
> (Updated Nov. 13, 2012, 11:11 a.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> Rework of metadatamusic qml components.
> Switched album and artist view to gridview.
> =
> Refactored MediaItemDelegate.qml and created new MediaItem.qml
> =
> =
> Diffs
> -----
> =
> browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccom=
ponents/MediaBrowser.qml 5218866 =
> =
> Diff: http://git.reviewboard.kde.org/r/107299/diff/
> =
> =
> Testing
> -------
> =
> =
> Screenshots
> -----------
> =
> Artist view
> http://git.reviewboard.kde.org/r/107299/s/827/
> Track view
> http://git.reviewboard.kde.org/r/107299/s/828/
> =
> =
> Thanks,
> =
> Fabian Riethmayer
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107299/">http://git.reviewboard.kde.org/r/107299/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i assume someone give \
this approval on irc so it was committed, but in future, please have the person who \
peer reviews the patch mark the review with "ShipIt!" so that we know it \
has actually seen peer review. thanks :)</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On November 13th, 2012, 11:11 a.m., Fabian Riethmayer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Fabian Riethmayer.</div>
<p style="color: grey;"><i>Updated Nov. 13, 2012, 11:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Rework of metadatamusic qml components. Switched album and artist view \
to gridview.
Refactored MediaItemDelegate.qml and created new MediaItem.qml
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml \
<span style="color: grey">(5218866)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107299/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107299/s/827/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/13/pmc-musicmetadatabackend_400x100.jpg" \
style="border: 1px black solid;" alt="Artist view" /></a>
<a href="http://git.reviewboard.kde.org/r/107299/s/828/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/13/pmc-musicmetadatabackend-2_400x100.jpg" \
style="border: 1px black solid;" alt="Track view" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic