[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Plasmate: Remove Python support for konsole previewer
From:       "Commit Hook" <null () kde ! org>
Date:       2012-11-12 21:51:58
Message-ID: 20121112215158.26210.660 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107209/#review21894
-----------------------------------------------------------


This review has been submitted with commit 37f8bbdfd3a3dd5922b59e89ad1c74d9=
34a44774 by Antonis Tsiapaliokas to branch master.

- Commit Hook


On Nov. 8, 2012, 2:05 p.m., Antonis Tsiapaliokas wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107209/
> -----------------------------------------------------------
> =

> (Updated Nov. 8, 2012, 2:05 p.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Description
> -------
> =

> Right now the python bindings doesn't support the kDebug, so the konsole =
previewer cannot return any output.
> Until this is fixed, we are disabling the python support for the konsole =
previewer.
> =

> =

> Diffs
> -----
> =

>   plasmate/mainwindow.h 6ac6fcd =

>   plasmate/mainwindow.cpp 9c19658 =

>   plasmate/previewer/plasmoid/previewcontainment.h 34dfb52 =

>   plasmate/previewer/plasmoid/previewcontainment.cpp 266baa4 =

>   plasmate/previewer/previewer.h 271bab8 =

>   plasmate/previewer/previewer.cpp 6f07098 =

> =

> Diff: http://git.reviewboard.kde.org/r/107209/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Antonis Tsiapaliokas
> =

>


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107209/">http://git.reviewboard.kde.org/r/107209/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 37f8bbdfd3a3dd5922b59e89ad1c74d934a44774 by Antonis \
Tsiapaliokas to branch master.</pre>  <br />







<p>- Commit</p>


<br />
<p>On November 8th, 2012, 2:05 p.m., Antonis Tsiapaliokas wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>


<p style="color: grey;"><i>Updated Nov. 8, 2012, 2:05 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Right now the python bindings doesn&#39;t support the kDebug, so the \
konsole previewer cannot return any output. Until this is fixed, we are disabling the \
python support for the konsole previewer.</pre>  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasmate/mainwindow.h <span style="color: grey">(6ac6fcd)</span></li>

 <li>plasmate/mainwindow.cpp <span style="color: grey">(9c19658)</span></li>

 <li>plasmate/previewer/plasmoid/previewcontainment.h <span style="color: \
grey">(34dfb52)</span></li>

 <li>plasmate/previewer/plasmoid/previewcontainment.cpp <span style="color: \
grey">(266baa4)</span></li>

 <li>plasmate/previewer/previewer.h <span style="color: grey">(271bab8)</span></li>

 <li>plasmate/previewer/previewer.cpp <span style="color: grey">(6f07098)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107209/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic