'Re: Review Request: Port the Calculator applet to QML'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Port the Calculator applet to QML
From:       "Commit Hook" <null () kde ! org>
Date:       2012-11-08 22:01:58
Message-ID: 20121108220158.8245.73373 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107001/#review21657
-----------------------------------------------------------

This review has been submitted with commit 08960f71610ffd869a7fafb495cfb24e=
2207bb0e by Luiz Rom=C3=A1rio Santana Rios to branch master.

- Commit Hook

On Nov. 6, 2012, 11:36 p.m., Rom=C3=A1rio Rios wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107001/
> -----------------------------------------------------------
> =

> (Updated Nov. 6, 2012, 11:36 p.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Description
> -------
> =

> This diff replaces the C++ Calculator applet by its QMLfied version, whic=
h seems to be feature-par with the latter.
> =

> =

> Diffs
> -----
> =

>   CMakeLists.txt 732145c =

>   calculator.h f7339be =

>   calculator.cpp 6bc3ddc =

>   package/contents/ui/calculator.qml PRE-CREATION =

>   package/metadata.desktop PRE-CREATION =

>   plasma-applet-calculator.desktop 0760729 =

> =

> Diff: http://git.reviewboard.kde.org/r/107001/diff/
> =

> =

> Testing
> -------
> =

> Tested as both applet and popupapplet, with the Air theme and the Oxygen =
theme. It seems to work fine.
> =

> =

> Thanks,
> =

> Rom=C3=A1rio Rios
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107001/">http://git.reviewboard.kde.org/r/107001/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 08960f71610ffd869a7fafb495cfb24e2207bb0e by Luiz Romário \
Santana Rios to branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On November 6th, 2012, 11:36 p.m., Romário Rios wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Romário Rios.</div>

<p style="color: grey;"><i>Updated Nov. 6, 2012, 11:36 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This diff replaces the C++ Calculator applet by its QMLfied version, \
which seems to be feature-par with the latter.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested as both applet and popupapplet, with the Air theme and the Oxygen \
theme. It seems to work fine.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(732145c)</span></li>

 <li>calculator.h <span style="color: grey">(f7339be)</span></li>

 <li>calculator.cpp <span style="color: grey">(6bc3ddc)</span></li>

 <li>package/contents/ui/calculator.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma-applet-calculator.desktop <span style="color: grey">(0760729)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107001/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 