[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: digital clock widget - popup focus
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2012-11-05 13:23:32
Message-ID: 20121105132332.11340.65347 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105933/#review21437
-----------------------------------------------------------
This is not a bug, but a feature. :)
The calendar, as opposed to most other widgets, is often used alongside other windows \
for reference. Say for example you're chatting with someone about an appointment, and \
want to peak at the calendar while discussing possible dates. If the calendar closed \
on losing focus, it would be highly annoying. We made a design decision that the use \
cases for the calendar are different enough to warrant the inconsistency in \
behaviour, that is why the popup of the calendar doesn't close, while others do -- \
they're used differently.
Sorry that the review request was lingering that long. I've also posted this comment \
as reply to the bugreport.
- Sebastian Kügler
On Aug. 20, 2012, 6:07 p.m., Greg T wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105933/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2012, 6:07 p.m.)
>
>
> Review request for Plasma and John Layt.
>
>
> Description
> -------
>
> For some reason for this widgt the option setPassivePopup is enabled (probably \
> because you can't control it with keyboard anyways). Interestingly, the result is \
> that the popup doesn't hide if you, for example, open the settings dialog. This \
> behaviour is a bug and not consistent with all other popup widgets.
> I suppose this fixes also https://bugs.kde.org/show_bug.cgi?id=221301
>
> On the other hand, we could also try to fix that passive popup feature, if it's \
> broken...I don't know.
>
> This addresses bug 221301.
> http://bugs.kde.org/show_bug.cgi?id=221301
>
>
> Diffs
> -----
>
> plasma/generic/applets/digital-clock/clock.cpp 1331776
>
> Diff: http://git.reviewboard.kde.org/r/105933/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg T
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105933/">http://git.reviewboard.kde.org/r/105933/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is not a bug, but a \
feature. :)
The calendar, as opposed to most other widgets, is often used alongside other windows \
for reference. Say for example you're chatting with someone about an appointment, \
and want to peak at the calendar while discussing possible dates. If the calendar \
closed on losing focus, it would be highly annoying. We made a design decision that \
the use cases for the calendar are different enough to warrant the inconsistency in \
behaviour, that is why the popup of the calendar doesn't close, while others do \
-- they're used differently.
Sorry that the review request was lingering that long. I've also posted this \
comment as reply to the bugreport.</pre> <br />
<p>- Sebastian</p>
<br />
<p>On August 20th, 2012, 6:07 p.m., Greg T wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and John Layt.</div>
<div>By Greg T.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2012, 6:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For some reason for this widgt the option setPassivePopup is enabled \
(probably because you can't control it with keyboard anyways). Interestingly, the \
result is that the popup doesn't hide if you, for example, open the settings \
dialog. This behaviour is a bug and not consistent with all other popup widgets.
I suppose this fixes also https://bugs.kde.org/show_bug.cgi?id=221301
On the other hand, we could also try to fix that passive popup feature, if it's \
broken...I don't know.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=221301">221301</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/digital-clock/clock.cpp <span style="color: \
grey">(1331776)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105933/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic