[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Kickoff-qml fixes
From: "Commit Hook" <null () kde ! org>
Date: 2012-11-04 3:17:58
Message-ID: 20121104031758.26641.6107 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107026/#review21398
-----------------------------------------------------------
This review has been submitted with commit 7ead86e6621de733f590ceff7ee14efa=
03806e89 by David Edmundson to branch kickoff-qml.
- Commit Hook
On Oct. 24, 2012, 6:20 p.m., David Edmundson wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107026/
> -----------------------------------------------------------
> =
> (Updated Oct. 24, 2012, 6:20 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> If an application has no generic name return the application name as the =
title.
> =
> In this case we return nothing as the subtitle. If the subtitle is the sa=
me as the new title, hide the subtitle.
> This fixes a bug in which "Find Files" would show with a subtitle but no =
title as well as "Utilities" having a pointless subtitle
> --
> Use standard desktop scrolling
> --
> Always show application subtitle. =
> =
> This makes it the same as previous kickoff. This subtitle is quite import=
ant when you have two web browsers (for example)
> --
> Increase padding on LHS between icon and text
> =
> =
> Diffs
> -----
> =
> plasma/desktop/applets/kickoff/core/applicationmodel.cpp fa5ceea58c4e7e=
27df1a65d5278510b2d0225ffa =
> plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml=
4488f2eaea0bc7447318ca341c5b27d6a4eee700 =
> plasma/desktop/applets/kickoff/package/contents/ui/BaseView.qml 2b1e598=
cc72a84639ecd467ed558276e972a3510 =
> plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 9d46=
8b2e596410eae18aba357bd6307b70758e33 =
> =
> Diff: http://git.reviewboard.kde.org/r/107026/diff/
> =
> =
> Testing
> -------
> =
> =
> Screenshots
> -----------
> =
> After
> http://git.reviewboard.kde.org/r/107026/s/799/
> =
> =
> Thanks,
> =
> David Edmundson
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107026/">http://git.reviewboard.kde.org/r/107026/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 7ead86e6621de733f590ceff7ee14efa03806e89 by David Edmundson to \
branch kickoff-qml.</pre> <br />
<p>- Commit</p>
<br />
<p>On October 24th, 2012, 6:20 p.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Oct. 24, 2012, 6:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If an application has no generic name return the application name as the \
title.
In this case we return nothing as the subtitle. If the subtitle is the same as the \
new title, hide the subtitle. This fixes a bug in which "Find Files" would \
show with a subtitle but no title as well as "Utilities" having a pointless \
subtitle
--
Use standard desktop scrolling
--
Always show application subtitle.
This makes it the same as previous kickoff. This subtitle is quite important when you \
have two web browsers (for example)
--
Increase padding on LHS between icon and text
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/kickoff/core/applicationmodel.cpp <span style="color: \
grey">(fa5ceea58c4e7e27df1a65d5278510b2d0225ffa)</span></li>
<li>plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml <span \
style="color: grey">(4488f2eaea0bc7447318ca341c5b27d6a4eee700)</span></li>
<li>plasma/desktop/applets/kickoff/package/contents/ui/BaseView.qml <span \
style="color: grey">(2b1e598cc72a84639ecd467ed558276e972a3510)</span></li>
<li>plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml <span \
style="color: grey">(9d468b2e596410eae18aba357bd6307b70758e33)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107026/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107026/s/799/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/24/kickoff-qml1_400x100.png" \
style="border: 1px black solid;" alt="After" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic