[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: load the images for the themes correctly
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2012-11-01 15:34:41
Message-ID: 20121101153441.13052.98753 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106680/#review21311
-----------------------------------------------------------
you mean they can't have different descriptions? yes, that's true, and no, =
that's how it should be. if they are the stored in the same key, they are t=
he same entry as far as the Package is concerned.
- Aaron J. Seigo
On Nov. 1, 2012, 3:08 p.m., Giorgos Tsiapaliokas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106680/
> -----------------------------------------------------------
> =
> (Updated Nov. 1, 2012, 3:08 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> create a new theme package->click on the new
> =
> a file dialog should appear but instead a simple edit box appears request=
ing a new filename.
> =
> This patch solves the issue
> =
> =
> Diffs
> -----
> =
> plasmate/editors/editpage.h 5cb3ea6 =
> plasmate/editors/editpage.cpp 7e82ff2 =
> plasmate/packagemodel.cpp 9eb0914 =
> =
> Diff: http://git.reviewboard.kde.org/r/106680/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Giorgos Tsiapaliokas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106680/">http://git.reviewboard.kde.org/r/106680/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you mean they can't \
have different descriptions? yes, that's true, and no, that's how it should \
be. if they are the stored in the same key, they are the same entry as far as the \
Package is concerned.</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On November 1st, 2012, 3:08 p.m., Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Nov. 1, 2012, 3:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">create a new theme package->click on the new
a file dialog should appear but instead a simple edit box appears requesting a new \
filename.
This patch solves the issue</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/editors/editpage.h <span style="color: grey">(5cb3ea6)</span></li>
<li>plasmate/editors/editpage.cpp <span style="color: grey">(7e82ff2)</span></li>
<li>plasmate/packagemodel.cpp <span style="color: grey">(9eb0914)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106680/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic