'Review Request: AppletContainer has moved to scriptengine'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: AppletContainer has moved to scriptengine
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2012-10-31 23:22:21
Message-ID: 20121031232221.1888.88045 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107165/
-----------------------------------------------------------

Review request for Plasma.

Description
-------

* remove AppletContainer from MobileComponents
* Port all uses of AppletContainer to org.kde.plasma.containments

This class has been moved into the scriptengine in kde-runtime (master), an=
d is
available for all containments as type.

My branch splits this up into two commits (one for the mobilecomponents and=
 one for the porting), I've put it into one review request since their both=
 closely related (and fairly trivial).

Diffs
-----

  components/mobilecomponents/CMakeLists.txt 981843c4be970c5aef450ef4cdc672=
1162f950c3 =

  components/mobilecomponents/appletcontainer.h 76587f2ca6131c228f70677b8c5=
f989039b3f4f6 =

  components/mobilecomponents/appletcontainer.cpp 2dc54092033e8d07737a2b31e=
006f8211137e48a =

  components/mobilecomponents/mobilecomponentsplugin.cpp 6a63631413a2508ba5=
47c2402803a45d07bb4d4a =

  containments/activityscreen/contents/ui/PlasmoidGroup.qml b394bc03f73c84d=
58aefd3a91ef4999f9703615a =

  containments/appletstrip/contents/ui/PlasmoidContainer.qml 70226dae7caf55=
c0d163490ee7b5375bda882ce6 =

  containments/systemtray/contents/ui/PlasmoidContainer.qml 270c4fcd5085a92=
36b48609caa03c98fa24fc453 =

Diff: http://git.reviewboard.kde.org/r/107165/diff/

Testing
-------

Tested actity screen and system tray in plasma-device and plasma-desktop an=
d plasmoidviewer, no errors.

Thanks,

Sebastian K=C3=BCgler

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107165/">http://git.reviewboard.kde.org/r/107165/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Sebastian Kügler.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">* remove AppletContainer from MobileComponents
* Port all uses of AppletContainer to org.kde.plasma.containments

This class has been moved into the scriptengine in kde-runtime (master), and is
available for all containments as type.

My branch splits this up into two commits (one for the mobilecomponents and one for \
the porting), I&#39;ve put it into one review request since their both closely \
related (and fairly trivial).

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested actity screen and system tray in plasma-device and plasma-desktop \
and plasmoidviewer, no errors.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>components/mobilecomponents/CMakeLists.txt <span style="color: \
grey">(981843c4be970c5aef450ef4cdc6721162f950c3)</span></li>

 <li>components/mobilecomponents/appletcontainer.h <span style="color: \
grey">(76587f2ca6131c228f70677b8c5f989039b3f4f6)</span></li>

 <li>components/mobilecomponents/appletcontainer.cpp <span style="color: \
grey">(2dc54092033e8d07737a2b31e006f8211137e48a)</span></li>

 <li>components/mobilecomponents/mobilecomponentsplugin.cpp <span style="color: \
grey">(6a63631413a2508ba547c2402803a45d07bb4d4a)</span></li>

 <li>containments/activityscreen/contents/ui/PlasmoidGroup.qml <span style="color: \
grey">(b394bc03f73c84d58aefd3a91ef4999f9703615a)</span></li>

 <li>containments/appletstrip/contents/ui/PlasmoidContainer.qml <span style="color: \
grey">(70226dae7caf55c0d163490ee7b5375bda882ce6)</span></li>

 <li>containments/systemtray/contents/ui/PlasmoidContainer.qml <span style="color: \
grey">(270c4fcd5085a9236b48609caa03c98fa24fc453)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107165/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 