From kde-panel-devel Tue Oct 30 12:47:28 2012 From: "Commit Hook" Date: Tue, 30 Oct 2012 12:47:28 +0000 To: kde-panel-devel Subject: Re: Review Request: refactor the package model Message-Id: <20121030124728.6172.50737 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=135161906112763 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0128850271347031284==" --===============0128850271347031284== Content-Type: multipart/alternative; boundary="===============6157923905920969528==" --===============6157923905920969528== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106742/#review21152 ----------------------------------------------------------- This review has been submitted with commit 38a0a8a0e7f2a765b181123a20dd4614= 404678b7 by Giorgos Tsiapaliokas to branch master. - Commit Hook On Oct. 30, 2012, 9:17 a.m., Giorgos Tsiapaliokas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106742/ > ----------------------------------------------------------- > = > (Updated Oct. 30, 2012, 9:17 a.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > This patch refactors the package model making it "smarter", > = > so the package model will > * create only the necessary files and dirs for a package > * a dir is empty it will be auto deleted > * the package model shows the description of the files(if it exists) inst= ead of their names > * if a main.xml file doesn't exist, the model will have an entry like "Ne= w Configuration XML", > the "New..." entry won't be there. > = > = > Diffs > ----- > = > plasmate/editors/editpage.h 8cc5fab = > plasmate/editors/editpage.cpp 91f6bce = > plasmate/mainwindow.cpp 9b38f2b = > plasmate/packagemodel.h 43b9df5 = > plasmate/packagemodel.cpp 67cc0f4 = > = > Diff: http://git.reviewboard.kde.org/r/106742/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Giorgos Tsiapaliokas > = > --===============6157923905920969528== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106742/ 

This revie=
w has been submitted with commit 38a0a8a0e7f2a765b181123a20dd4614404678b7 b=
y Giorgos Tsiapaliokas to branch master.

- Commit


On October 30th, 2012, 9:17 a.m., Giorgos Tsiapaliokas wrote:

Review request for Plasma.
By Giorgos Tsiapaliokas.

Updated Oct. 30, 2012, 9:17 a.m.

Descripti= on 

This patch refactors the package model making it "smart=
er",

so the package model will
* create only the necessary files and dirs for a package
* a dir is empty it will be auto deleted
* the package model shows the description of the files(if it exists) instea=
d of their names
* if a main.xml file doesn't exist, the model will have an entry like &=
quot;New Configuration XML",
   the "New..." entry won't be there.

Diffs=

  • plasmate/editors/editpage.h (8cc5fab)
  • plasmate/editors/editpage.cpp (91f6bce)
  • plasmate/mainwindow.cpp (9b38f2b)
  • plasmate/packagemodel.h (43b9df5)
  • plasmate/packagemodel.cpp (67cc0f4)=

View Diff
--===============6157923905920969528==-- --===============0128850271347031284== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0128850271347031284==--