--===============5221182817949663186== Content-Type: multipart/alternative; boundary="===============4951839165803807169==" --===============4951839165803807169== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106582/ ----------------------------------------------------------- (Updated Oct. 30, 2012, 12:39 p.m.) Review request for Plasma. Changes ------- I have fixed the issues.. I have tested the plasmoid in two machines. In mine it doesn't work well, in the other one it does. Do we have a third volunteer? :) P.S.: tomorrow I will clean my system and I will try it. Description ------- I have populated the settings of the rssnow-qml plasmoid and they are identical to the ones of the c++ one. In order to do that I made the rssnow-qml plasmoid into a hybrid. After submit of this review I believe that it is ready to be moved into the kdeplasma-addons and to remove the c++ one. (I would prefer to open a new review for the move) Also I have pushed the latest changes(this diff) into the terietor/rssnow/settings branch in declarative-plasmoids Diffs (updated) ----- rssnow/package/metadata.desktop ef72f15 = rssnow/plasma-applet-rssnow-qml.desktop ef72f15 = rssnow/plasma-applet-rssnow.desktop PRE-CREATION = rssnow/rssnow.h PRE-CREATION = rssnow/rssnow.cpp PRE-CREATION = rssnow/feedsConfig.ui PRE-CREATION = rssnow/generalConfig.ui PRE-CREATION = rssnow/package/contents/config/main.xml e05fcbf = rssnow/package/contents/ui/DropRssEntry.qml PRE-CREATION = rssnow/package/contents/ui/ListItemEntry.qml 657b14b = rssnow/package/contents/ui/config.ui e1e3409 = rssnow/package/contents/ui/main.qml a575c29 = rssnow/CMakeLists.txt 79b3581 = Diff: http://git.reviewboard.kde.org/r/106582/diff/ Testing ------- Thanks, Giorgos Tsiapaliokas --===============4951839165803807169== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106582/

Review request for Plasma.
By Giorgos Tsiapaliokas.

Updated Oct. 30, 2012, 12:39 p.m.

Changes
I have fixed the issues..

I have tested the plasmoid in two machines.
In mine it doesn't work well, in the other one it does.

Do we have a third volunteer? :)

P.S.: tomorrow I will clean my system and I will try it.

Descripti= on

I have populated the settings of the rssnow-qml plasmoid
and they are identical to the ones of the c++ one.

In order to do that I made the rssnow-qml plasmoid into a hybrid.

After submit of this review I believe that it is ready to be
moved into the kdeplasma-addons and to remove the c++ one.
(I would prefer to open a new review for the move)

Also I have pushed the latest changes(this diff) into the
terietor/rssnow/settings branch in declarative-plasmoids

Diffs= (updated)

  • rssnow/package/metadata.desktop (ef72f15)<= /span>
  • rssnow/plasma-applet-rssnow-qml.desktop (e= f72f15)
  • rssnow/plasma-applet-rssnow.desktop (PRE-C= REATION)
  • rssnow/rssnow.h (PRE-CREATION)
  • rssnow/rssnow.cpp (PRE-CREATION)
  • rssnow/feedsConfig.ui (PRE-CREATION)
  • rssnow/generalConfig.ui (PRE-CREATION)
  • rssnow/package/contents/config/main.xml (e= 05fcbf)
  • rssnow/package/contents/ui/DropRssEntry.qml (657b14b)
  • rssnow/package/contents/ui/config.ui (e1e3= 409)
  • rssnow/package/contents/ui/main.qml (a575c= 29)
  • rssnow/CMakeLists.txt (79b3581)

View Diff

--===============4951839165803807169==-- --===============5221182817949663186== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5221182817949663186==--