--===============8171619201831260744== Content-Type: multipart/alternative; boundary="===============8185781697133871084==" --===============8185781697133871084== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106680/#review21141 ----------------------------------------------------------- plasmate/editors/editpage.cpp yes, so it should use startsWith :) = the code in the current patch is functionally equivalent to: = const QString themeType =3D "[plasmate]/themeImageDialog/"; if (mimetype.startsWith(themeType)) { const QString opts =3D "cotents/" + mimetype.right(mimetype.size() = - themeType.length()); imageDialog(commonFilter, opts); } - Aaron J. Seigo On Oct. 4, 2012, 10:49 a.m., Giorgos Tsiapaliokas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106680/ > ----------------------------------------------------------- > = > (Updated Oct. 4, 2012, 10:49 a.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > create a new theme package->click on the new > = > a file dialog should appear but instead a simple edit box appears request= ing a new filename. > = > This patch solves the issue > = > = > Diffs > ----- > = > plasmate/editors/editpage.h 8cc5fab = > plasmate/editors/editpage.cpp 91f6bce = > plasmate/packagemodel.cpp 67cc0f4 = > = > Diff: http://git.reviewboard.kde.org/r/106680/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Giorgos Tsiapaliokas > = > --===============8185781697133871084== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106680/

= = = = = =

plasmate/editors/editpage.cpp (Diff revision 2)
void EditPage::findEditor(const QModelIndex &index)
		127	QHashIterator= <QString, QString> = i(theme= ImageDialogOptions);
		128	while (i.hasNext()) = {
		129	i.next();=
		130	if (mimetype =3D= =3D i.key()) {
		131	imageDialog<= /span>(commonFilter, i.value());
117	return;	132	return;
118	}	133	}
		134	}

yes, so it should use startsWith :)

the code in the current patch is functionally equivalent to:

const QString themeType =3D "[plasmate]/themeImageDialog/";
if (mimetype.startsWith(themeType)) {
    const QString opts =3D "cotents/" + mimetype.right(mimetype.s=
ize() - themeType.length());
    imageDialog(commonFilter, opts);
}

- Aaron J.

On October 4th, 2012, 10:49 a.m., Giorgos Tsiapaliokas wrote:

Review request for Plasma.

By Giorgos Tsiapaliokas.

Updated Oct. 4, 2012, 10:49 a.m.

Descripti= on

create a new theme package->click on the new

a file dialog should appear but instead a simple edit box appears requestin=
g a new filename.

This patch solves the issue

Diffs=

plasmate/editors/editpage.h (8cc5fab)
plasmate/editors/editpage.cpp (91f6bce)
plasmate/packagemodel.cpp (67cc0f4)=

--===============8185781697133871084==-- --===============8171619201831260744== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8171619201831260744==--