This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106680/

plasmate/editors/editpage.cpp (Diff revision 2)
void EditPage::findEditor(const QModelIndex &index)
		127	QHashIterator<QString, QString> i(themeImageDialogOptions);
		128	while (i.hasNext()) {
		129	i.next();
		130	if (mimetype == i.key()) {
		131	imageDialog(commonFilter, i.value());
117	return;	132	return;
118	}	133	}
		134	}

yes, so it should use startsWith :)

the code in the current patch is functionally equivalent to:

const QString themeType = "[plasmate]/themeImageDialog/";
if (mimetype.startsWith(themeType)) {
    const QString opts = "cotents/" + mimetype.right(mimetype.size() - themeType.length());
    imageDialog(commonFilter, opts);
}

- Aaron J.

On October 4th, 2012, 10:49 a.m., Giorgos Tsiapaliokas wrote:

Review request for Plasma.

By Giorgos Tsiapaliokas.

Updated Oct. 4, 2012, 10:49 a.m.

Description

create a new theme package->click on the new

a file dialog should appear but instead a simple edit box appears requesting a new filename.

This patch solves the issue

Diffs

plasmate/editors/editpage.h (8cc5fab)
plasmate/editors/editpage.cpp (91f6bce)
plasmate/packagemodel.cpp (67cc0f4)

View Diff