'Re: Review Request: refactor the package model'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: refactor the package model
From:       "Giorgos Tsiapaliokas" <terietor () gmail ! com>
Date:       2012-10-30 9:17:44
Message-ID: 20121030091744.19930.73525 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106742/
-----------------------------------------------------------

(Updated Oct. 30, 2012, 9:17 a.m.)

Review request for Plasma.

Changes
-------

I have fixed the issues

Description
-------

This patch refactors the package model making it "smarter",

so the package model will
* create only the necessary files and dirs for a package
* a dir is empty it will be auto deleted
* the package model shows the description of the files(if it exists) instea=
d of their names
* if a main.xml file doesn't exist, the model will have an entry like "New =
Configuration XML",
   the "New..." entry won't be there.

Diffs (updated)
-----

  plasmate/editors/editpage.h 8cc5fab =

  plasmate/editors/editpage.cpp 91f6bce =

  plasmate/mainwindow.cpp 9b38f2b =

  plasmate/packagemodel.h 43b9df5 =

  plasmate/packagemodel.cpp 67cc0f4 =

Diff: http://git.reviewboard.kde.org/r/106742/diff/

Testing
-------

Thanks,

Giorgos Tsiapaliokas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106742/">http://git.reviewboard.kde.org/r/106742/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated Oct. 30, 2012, 9:17 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have fixed the issues</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch refactors the package model making it &quot;smarter&quot;,

so the package model will
* create only the necessary files and dirs for a package
* a dir is empty it will be auto deleted
* the package model shows the description of the files(if it exists) instead of their \
                names
* if a main.xml file doesn&#39;t exist, the model will have an entry like &quot;New \
Configuration XML&quot;,  the &quot;New...&quot; entry won&#39;t be there.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>plasmate/editors/editpage.h <span style="color: grey">(8cc5fab)</span></li>

 <li>plasmate/editors/editpage.cpp <span style="color: grey">(91f6bce)</span></li>

 <li>plasmate/mainwindow.cpp <span style="color: grey">(9b38f2b)</span></li>

 <li>plasmate/packagemodel.h <span style="color: grey">(43b9df5)</span></li>

 <li>plasmate/packagemodel.cpp <span style="color: grey">(67cc0f4)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106742/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 