[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix Inconsistencies and Bugs in Activity Bar's Size Hinting
From: David_Narváez <david.narvaez () computer ! org>
Date: 2012-10-27 12:02:57
Message-ID: 20121027120257.15427.62357 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 25, 2012, 9:44 a.m., Aaron J. Seigo wrote:
> > there are a number of style issues with this patch, but the real problem is \
> > setting it to a hardcoded 1/3rd of the panel.
> > i would suggest that the real underlying problem here is that the m_tabBar \
> > sizehint keeps changing so radically.
I have limited internet access from my development machine during these days, but \
I'll try addressing the m_tabBar sizeHint issue ASAP. Yet, even if that bug is fixed, \
for 8+ activities, I personallly prefer the tab bar to take only a given amount of \
space (independent of the number of tabs) and display arrows, see
http://mail.kde.org/pipermail/plasma-devel/2011-November/017890.html
I will work through the style issues if possible, but there are some comments below \
I'd like to discuss.
> On Oct. 25, 2012, 9:44 a.m., Aaron J. Seigo wrote:
> > plasma/generic/applets/activitybar/activitybar.cpp, line 37
> > <http://git.reviewboard.kde.org/r/106978/diff/1/?file=91763#file91763line37>
> >
> > this should be a member of the class (the hint should have been passing in *this \
> > constantly); perhaps call it 'calculatePreferredSize" to avoid conflicting with \
> > setPreferredSize
I obviously chose this design to avoid braking the ABI.
> On Oct. 25, 2012, 9:44 a.m., Aaron J. Seigo wrote:
> > plasma/generic/applets/activitybar/activitybar.cpp, lines 42-45
> > <http://git.reviewboard.kde.org/r/106978/diff/1/?file=91763#file91763line42>
> >
> > 1/3rd looks wrong and is going to give incorrect results in several situations \
> > (e.g. when pref size of all plasmoids fit, but the activity bar has fewer buttons \
> > than the space it is alloted)
That's intended. If the space alloted is greater than the size required to display \
the few tabs, the tabs expand to fit the size and the look is similar to what we have \
now (which is, by the way, horrible) just not constantly expanding. On the other \
hand, if you have 8+ tabs, they will not fit in the 1/3 size and the tab bar will \
display arrows for scrolling left or right.
Taking any approach that varies with the amount of tabs is actually against the \
principle of least astonishment, from my point of view.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106978/#review20847
-----------------------------------------------------------
On Oct. 22, 2012, 2:27 a.m., David Narváez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106978/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2012, 2:27 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> The main issue was caused by the fact that asking the tab bar native widget to \
> provide a size hint was giving a different size every time which caused the \
> activity bar to expand or shrink in the presence of another expanding widget (in my \
> case, the taskbar), so this patch decides a size hint from the size of the \
> containment (one third of the width of height depending on the form factor) but the \
> size policy is set to expand when the activity bar is the only widget in the \
> containment.
>
> This addresses bug 225078.
> http://bugs.kde.org/show_bug.cgi?id=225078
>
>
> Diffs
> -----
>
> plasma/generic/applets/activitybar/activitybar.cpp e66bf04
>
> Diff: http://git.reviewboard.kde.org/r/106978/diff/
>
>
> Testing
> -------
>
> 1) Add a panel with an actyivity bar and a task bar
> 2) Add a panel with an activty bar only
> 3) Change activities
>
> Before this patch, the activity bar in the panel with a task bar shrinks or \
> enlarges with every activity change; while the size of the activity bar in the \
> second panel remains constant. After this patch, the size of the activity bar in \
> both panels remains constant.
>
> Thanks,
>
> David Narváez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106978/">http://git.reviewboard.kde.org/r/106978/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 25th, 2012, 9:44 a.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">there are a number of style issues with this patch, but the real problem \
is setting it to a hardcoded 1/3rd of the panel.
i would suggest that the real underlying problem here is that the m_tabBar sizehint \
keeps changing so radically.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have limited internet \
access from my development machine during these days, but I'll try addressing the \
m_tabBar sizeHint issue ASAP. Yet, even if that bug is fixed, for 8+ activities, I \
personallly prefer the tab bar to take only a given amount of space (independent of \
the number of tabs) and display arrows, see
http://mail.kde.org/pipermail/plasma-devel/2011-November/017890.html
I will work through the style issues if possible, but there are some comments below \
I'd like to discuss.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 25th, 2012, 9:44 a.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106978/diff/1/?file=91763#file91763line37" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/activitybar/activitybar.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">37</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">setPreferredSize</span><span \
class="p">(</span><span class="n">ActivityBar</span> <span class="o">&</span> \
<span class="n">bar</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this should be a member \
of the class (the hint should have been passing in *this constantly); perhaps call it \
'calculatePreferredSize" to avoid conflicting with setPreferredSize</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I obviously \
chose this design to avoid braking the ABI.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 25th, 2012, 9:44 a.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106978/diff/1/?file=91763#file91763line42" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/activitybar/activitybar.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">42</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">bar</span><span class="p">.</span><span \
class="n">setPreferredSize</span><span class="p">(</span><span \
class="n">QSizeF</span><span class="p">(</span><span \
class="n">containmentRect</span><span class="p">.</span><span \
class="n">width</span><span class="p">()</span> <span class="o">/</span> <span \
class="mi">3</span><span class="p">,</span> <span \
class="n">containmentRect</span><span class="p">.</span><span \
class="n">height</span><span class="p">()));</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">43</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">break</span><span class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">44</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">case</span> <span class="n">Plasma</span><span class="o">::</span><span \
class="nl">Vertical:</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">45</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">bar</span><span class="p">.</span><span \
class="n">setPreferredSize</span><span class="p">(</span><span \
class="n">QSizeF</span><span class="p">(</span><span \
class="n">containmentRect</span><span class="p">.</span><span \
class="n">width</span><span class="p">(),</span> <span \
class="n">containmentRect</span><span class="p">.</span><span \
class="n">height</span><span class="p">()</span> <span class="o">/</span> <span \
class="mi">3</span><span class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1/3rd looks wrong and is \
going to give incorrect results in several situations (e.g. when pref size of all \
plasmoids fit, but the activity bar has fewer buttons than the space it is \
alloted)</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's \
intended. If the space alloted is greater than the size required to display the few \
tabs, the tabs expand to fit the size and the look is similar to what we have now \
(which is, by the way, horrible) just not constantly expanding. On the other hand, if \
you have 8+ tabs, they will not fit in the 1/3 size and the tab bar will display \
arrows for scrolling left or right.
Taking any approach that varies with the amount of tabs is actually against the \
principle of least astonishment, from my point of view.</pre> <br />
<p>- David</p>
<br />
<p>On October 22nd, 2012, 2:27 a.m., David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated Oct. 22, 2012, 2:27 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The main issue was caused by the fact that asking the tab bar native \
widget to provide a size hint was giving a different size every time which caused the \
activity bar to expand or shrink in the presence of another expanding widget (in my \
case, the taskbar), so this patch decides a size hint from the size of the \
containment (one third of the width of height depending on the form factor) but the \
size policy is set to expand when the activity bar is the only widget in the \
containment.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1) Add a panel with an actyivity bar and a task bar 2) Add a panel with \
an activty bar only 3) Change activities
Before this patch, the activity bar in the panel with a task bar shrinks or enlarges \
with every activity change; while the size of the activity bar in the second panel \
remains constant. After this patch, the size of the activity bar in both panels \
remains constant.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=225078">225078</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/activitybar/activitybar.cpp <span style="color: \
grey">(e66bf04)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106978/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic