[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request: Convert file content to local encoding before uploading text file in the "share" dat
From: "Yichao Yu" <yyc1992 () gmail ! com>
Date: 2012-10-25 20:35:31
Message-ID: 20121025203531.17132.25744 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107044/
-----------------------------------------------------------
Review request for Plasma.
Description
-------
When dragging a text file with utf8 characters to the PasteBin plasma apple=
t, it will upload the file in the wrong encoding. This patch decode the fil=
e content using current locale which should be a better option than the def=
ault one (Latin1?).
Diffs
-----
plasma/generic/dataengines/share/shareprovider.cpp 81ac677 =
Diff: http://git.reviewboard.kde.org/r/107044/diff/
Testing
-------
Compiled, installed, upload a file with utf8 characters and the encoding is=
correct.
Thanks,
Yichao Yu
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107044/">http://git.reviewboard.kde.org/r/107044/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Yichao Yu.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When dragging a text file with utf8 characters to the PasteBin plasma \
applet, it will upload the file in the wrong encoding. This patch decode the file \
content using current locale which should be a better option than the default one \
(Latin1?). </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled, installed, upload a file with utf8 characters and the encoding \
is correct.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/dataengines/share/shareprovider.cpp <span style="color: \
grey">(81ac677)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107044/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic