--===============3697453887014842249== Content-Type: multipart/alternative; boundary="===============2744173214525340455==" --===============2744173214525340455== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Oct. 25, 2012, 11:36 a.m., Aaron J. Seigo wrote: > > the real fix here is to not use IconWidget :) that's a QGraphicsWidget = thing and will need to be replaced eventually anyways. > > = > > this should be using the Button QML element, which does support using S= VG files. > = > Dmitry Ashkadov wrote: > IconWidget supports QAction so it's possible to handle global shortcu= ts. Does QML Button support QAction? Or is is another way to handle global = shortcuts from QML? not automatically, no. but QActions are QObjects, so you can attach to thei= r signals in the QML. - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107017/#review20863 ----------------------------------------------------------- On Oct. 24, 2012, 1:02 p.m., Dmitry Ashkadov wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107017/ > ----------------------------------------------------------- > = > (Updated Oct. 24, 2012, 1:02 p.m.) > = > = > Review request for kdelibs and Plasma. > = > = > Description > ------- > = > New System tray uses IconWidget QML item, but it isn't possible to set sv= g image with specified element id. Now I use Svg QML item to load svg and t= hen pass icon to IconWidget, moreover svg is converted to pixmap (: . At th= e same time IconWidget can handle svg images, so these small changes make m= e happy :) because I will can eliminate usage of Svg QML items for arrow an= d Dbus tasks in system tray. = > = > = > Diffs > ----- > = > plasma/widgets/iconwidget.h 78f392e = > plasma/widgets/iconwidget.cpp a2092a4 = > = > Diff: http://git.reviewboard.kde.org/r/107017/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Dmitry Ashkadov > = > --===============2744173214525340455== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107017/ |
On October 25th, 2012, 11:36 a.m., Aaron J.= Seigo wrote:
the real = fix here is to not use IconWidget :) that's a QGraphicsWidget thing and= will need to be replaced eventually anyways. this should be using the Button QML element, which does support using SVG f= iles.On October 25th, 2012, 12:55 p.m., Dmitry Ashkadov wrote:
IconWidge= t supports QAction so it's possible to handle global shortcuts. Does QM= L Button support QAction? Or is is another way to handle global shortcuts f= rom QML?
not automat= ically, no. but QActions are QObjects, so you can attach to their signals i= n the QML.
- Aaron J.
On October 24th, 2012, 1:02 p.m., Dmitry Ashkadov wrote:
Review request for kdelibs and Plasma.
By Dmitry Ashkadov.
Updated Oct. 24, 2012, 1:02 p.m. Descripti= on
Diffs=
|