This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107017/

On October 25th, 2012, 11:36 a.m., Aaron J. Seigo wrote:

the real fix here is to not use IconWidget :) that's a QGraphicsWidget thing and will need to be replaced eventually anyways.

this should be using the Button QML element, which does support using SVG files. 

On October 25th, 2012, 12:55 p.m., Dmitry Ashkadov wrote:

IconWidget supports QAction so it's possible to handle global shortcuts. Does QML Button support QAction? Or is is another way to handle global shortcuts from QML?
not automatically, no. but QActions are QObjects, so you can attach to their signals in the QML.

- Aaron J.


On October 24th, 2012, 1:02 p.m., Dmitry Ashkadov wrote:

Review request for kdelibs and Plasma.
By Dmitry Ashkadov.

Updated Oct. 24, 2012, 1:02 p.m.

Description

New System tray uses IconWidget QML item, but it isn't possible to set svg image with specified element id. Now I use Svg QML item to load svg and then pass icon to IconWidget, moreover svg is converted to pixmap (: . At the same time IconWidget can handle svg images, so these small changes make me happy :) because I will can eliminate usage of Svg QML items for arrow and Dbus tasks in system tray. 

Diffs

  • plasma/widgets/iconwidget.h (78f392e)
  • plasma/widgets/iconwidget.cpp (a2092a4)

View Diff