--===============7609300327635702156== Content-Type: multipart/alternative; boundary="===============4570550705955818237==" --===============4570550705955818237== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106937/#review20874 ----------------------------------------------------------- This review has been submitted with commit 6fe8ee6ed91ac087177760990da63b1a= 8e5f6de4 by Sebastian K=C3=BCgler to branch KDE/4.9. - Commit Hook On Oct. 18, 2012, 2:39 a.m., Sebastian K=C3=BCgler wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106937/ > ----------------------------------------------------------- > = > (Updated Oct. 18, 2012, 2:39 a.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > Check if referenced objects are valid > = > This kills two ReferenceErrors I'm seeing when using ListItems inside > VisualItemModels (in this case, there's no view and visual parent > attached on creation). > = > = > Diffs > ----- > = > plasma/declarativeimports/plasmacomponents/qml/ListItem.qml e352eb0 = > = > Diff: http://git.reviewboard.kde.org/r/106937/diff/ > = > = > Testing > ------- > = > tried the news app and widgetgallery, no regressions seen. > = > = > Thanks, > = > Sebastian K=C3=BCgler > = > --===============4570550705955818237== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106937/

This revie=
w has been submitted with commit 6fe8ee6ed91ac087177760990da63b1a8e5f6de4 b=
y Sebastian K=C3=BCgler to branch KDE/4.9.

- Commit

On October 18th, 2012, 2:39 a.m., Sebastian K=C3=BCgler wrote:

Review request for Plasma.

By Sebastian K=C3=BCgler.

Updated Oct. 18, 2012, 2:39 a.m.

Descripti= on

    Check if referenced objects are valid
    =

    This kills two ReferenceErrors I'm seeing when using ListItems insi=
de
    VisualItemModels (in this case, there's no view and visual parent
    attached on creation).

Testing <= /h1>

tried the news app and widgetgallery, no regressions seen.

Diffs=

plasma/declarativeimports/plasmacomponents/qml/ListItem.qml (e352eb0)

View Diff

--===============4570550705955818237==-- --===============7609300327635702156== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7609300327635702156==--