[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: make kickoff-qml partly c++, restores simpleapplet, applet type switch
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2012-10-25 9:29:21
Message-ID: 20121025092921.23225.84429 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 19, 2012, 3:09 p.m., Greg T wrote:
> > looks good, just a couple of notes:
> > why are you installing 2 desktop files for the kickoff launcher:
> > - metadata.desktop and the old plasma-applet-launcher.desktop
> > - we don't need CMakeLists.txt in core/ anymore?
> > - also it conflicts with my last commit in kickoff-qml (just a minor in=
kickoff.qml)
> =
> Marco Martin wrote:
> yep, 2 desktop files get installed unfortunately, is used in the hybr=
id plasmoids, don't see much alternative unfortunately.
> luckily metadata.desktop is local in the package so doesn't go to pol=
lute the syscoca db
> =
> i resolved the conflict and removed the other files besides cmakefile=
in core
> (pretty much all of ui/ and the config stuff in the package)
the solution to the 2 .desktop files is to make a policy for c++ plasmoids =
that automatically associates a qml package matching their c++ pluginName w=
ith them.
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106947/#review20575
-----------------------------------------------------------
On Oct. 19, 2012, 1:04 p.m., Marco Martin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106947/
> -----------------------------------------------------------
> =
> (Updated Oct. 19, 2012, 1:04 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> this makes the simple laucher work again, and since kickoff is in part c+=
+, the menu editor option as well as the switch from kickoff to classic wor=
ks again.
> =
> main reason of this tough is to eliminate the org.kde.kickoff import, tha=
t shouldn't be public api
> =
> =
> Diffs
> -----
> =
> plasma/desktop/applets/kickoff/CMakeLists.txt 4f61700 =
> plasma/desktop/applets/kickoff/applet/applet.h f3afe73 =
> plasma/desktop/applets/kickoff/applet/applet.cpp a6f7379 =
> plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 4d0e=
218 =
> plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml f953565 =
> plasma/desktop/applets/kickoff/package/metadata.desktop 9cb997d =
> plasma/desktop/applets/kickoff/simpleapplet/menuview.cpp 963c18b =
> plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp 28fba18 =
> =
> Diff: http://git.reviewboard.kde.org/r/106947/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Marco Martin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106947/">http://git.reviewboard.kde.org/r/106947/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 19th, 2012, 3:09 p.m., <b>Greg T</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good, \
just a couple of notes: why are you installing 2 desktop files for the kickoff \
launcher:
- metadata.desktop and the old plasma-applet-launcher.desktop
- we don't need CMakeLists.txt in core/ anymore?
- also it conflicts with my last commit in kickoff-qml (just a minor in \
kickoff.qml)</pre> </blockquote>
<p>On October 19th, 2012, 4:15 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yep, 2 desktop files get \
installed unfortunately, is used in the hybrid plasmoids, don't see much \
alternative unfortunately. luckily metadata.desktop is local in the package so \
doesn't go to pollute the syscoca db
i resolved the conflict and removed the other files besides cmakefile in core
(pretty much all of ui/ and the config stuff in the package)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the solution to the 2 \
.desktop files is to make a policy for c++ plasmoids that automatically associates a \
qml package matching their c++ pluginName with them.</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On October 19th, 2012, 1:04 p.m., Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Oct. 19, 2012, 1:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this makes the simple laucher work again, and since kickoff is in part \
c++, the menu editor option as well as the switch from kickoff to classic works \
again.
main reason of this tough is to eliminate the org.kde.kickoff import, that \
shouldn't be public api</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/kickoff/CMakeLists.txt <span style="color: \
grey">(4f61700)</span></li>
<li>plasma/desktop/applets/kickoff/applet/applet.h <span style="color: \
grey">(f3afe73)</span></li>
<li>plasma/desktop/applets/kickoff/applet/applet.cpp <span style="color: \
grey">(a6f7379)</span></li>
<li>plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml <span \
style="color: grey">(4d0e218)</span></li>
<li>plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml <span \
style="color: grey">(f953565)</span></li>
<li>plasma/desktop/applets/kickoff/package/metadata.desktop <span style="color: \
grey">(9cb997d)</span></li>
<li>plasma/desktop/applets/kickoff/simpleapplet/menuview.cpp <span style="color: \
grey">(963c18b)</span></li>
<li>plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp <span style="color: \
grey">(28fba18)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106947/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic