[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Containments expose an AppletContainer
From: "Commit Hook" <null () kde ! org>
Date: 2012-10-24 22:03:39
Message-ID: 20121024220339.3395.20090 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106817/#review20826
-----------------------------------------------------------
This review has been submitted with commit 347f21341d4eef9326893a7a0bf4314c=
0ebd7769 by Sebastian K=C3=BCgler to branch master.
- Commit Hook
On Oct. 13, 2012, 12:43 a.m., Sebastian K=C3=BCgler wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106817/
> -----------------------------------------------------------
> =
> (Updated Oct. 13, 2012, 12:43 a.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> This adds a class to manipulate applets in more detail in context of
> containments. The type will only be available from Containments, not
> Applets of PopupApplets.
> =
> This binds the necessary functionality of Applets to build fully
> features containments. The code has been moved from MobileComponents,
> untangling another piece there and putting the functionality where it
> belongs, into the specific component type bindings to allow this func=
tionality =
> also outside of plasma-mobile and further reduce the delta between th=
e shell =
> implementations.
> =
> Intended for kde-runtime master.
> =
> =
> Diffs
> -----
> =
> plasma/scriptengines/javascript/CMakeLists.txt d259b7f =
> plasma/scriptengines/javascript/plasmoid/appletcontainer.h PRE-CREATION =
> plasma/scriptengines/javascript/plasmoid/appletcontainer.cpp PRE-CREATI=
ON =
> plasma/scriptengines/javascript/plasmoid/appletinterface.cpp 46a644a =
> =
> Diff: http://git.reviewboard.kde.org/r/106817/diff/
> =
> =
> Testing
> -------
> =
> The code has been used for some time in Plasma Active, so can be consider=
ed stable and well tested. Also tested with a new Containment, works as exp=
ected.
> =
> =
> Thanks,
> =
> Sebastian K=C3=BCgler
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106817/">http://git.reviewboard.kde.org/r/106817/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 347f21341d4eef9326893a7a0bf4314c0ebd7769 by Sebastian Kügler \
to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On October 13th, 2012, 12:43 a.m., Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated Oct. 13, 2012, 12:43 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> This adds a class to manipulate applets in more detail in context of \
containments. The type will only be available from Containments, not Applets of \
PopupApplets.
This binds the necessary functionality of Applets to build fully
features containments. The code has been moved from MobileComponents,
untangling another piece there and putting the functionality where it
belongs, into the specific component type bindings to allow this functionality
also outside of plasma-mobile and further reduce the delta between the shell
implementations.
Intended for kde-runtime master.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The code has been used for some time in Plasma Active, so can be \
considered stable and well tested. Also tested with a new Containment, works as \
expected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/scriptengines/javascript/CMakeLists.txt <span style="color: \
grey">(d259b7f)</span></li>
<li>plasma/scriptengines/javascript/plasmoid/appletcontainer.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/scriptengines/javascript/plasmoid/appletcontainer.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/scriptengines/javascript/plasmoid/appletinterface.cpp <span style="color: \
grey">(46a644a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106817/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic