'Re: Review Request: Possibility to change an element ID of svg image in IconWidget'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Possibility to change an element ID of svg image in IconWidget
From:       "Dmitry Ashkadov" <dmitry.ashkadov () rosalab ! ru>
Date:       2012-10-24 13:02:32
Message-ID: 20121024130232.17401.9322 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107017/
-----------------------------------------------------------

(Updated Oct. 24, 2012, 1:02 p.m.)

Review request for kdelibs and Plasma.

Changes
-------

IconWidget's properties 'svg' and 'elementId' should be independent

Description
-------

New System tray uses IconWidget QML item, but it isn't possible to set svg =
image with specified element id. Now I use Svg QML item to load svg and the=
n pass icon to IconWidget, moreover svg is converted to pixmap (: . At the =
same time IconWidget can handle svg images, so these small changes make me =
happy :) because I will can eliminate usage of Svg QML items for arrow and =
Dbus tasks in system tray. =

Diffs (updated)
-----

  plasma/widgets/iconwidget.h 78f392e =

  plasma/widgets/iconwidget.cpp a2092a4 =

Diff: http://git.reviewboard.kde.org/r/107017/diff/

Testing
-------

Thanks,

Dmitry Ashkadov

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107017/">http://git.reviewboard.kde.org/r/107017/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs and Plasma.</div>
<div>By Dmitry Ashkadov.</div>

<p style="color: grey;"><i>Updated Oct. 24, 2012, 1:02 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">IconWidget&#39;s properties &#39;svg&#39; and &#39;elementId&#39; should \
be independent</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">New System tray uses IconWidget QML item, but it isn&#39;t possible to \
set svg image with specified element id. Now I use Svg QML item to load svg and then \
pass icon to IconWidget, moreover svg is converted to pixmap (: . At the same time \
IconWidget can handle svg images, so these small changes make me happy :) because I \
will can eliminate usage of Svg QML items for arrow and Dbus tasks in system tray. \
</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/widgets/iconwidget.h <span style="color: grey">(78f392e)</span></li>

 <li>plasma/widgets/iconwidget.cpp <span style="color: grey">(a2092a4)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107017/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 