'Review Request: Port the Calculator applet to QML'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Port the Calculator applet to QML
From:       Romário_Rios <luizromario () gmail ! com>
Date:       2012-10-23 1:31:59
Message-ID: 20121023013159.18142.35547 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107001/
-----------------------------------------------------------

Review request for Plasma.

Description
-------

This diff replaces the C++ Calculator applet by its QMLfied version, which =
seems to be feature-par with the latter.

Diffs
-----

  applets/calculator/CMakeLists.txt 732145c =

  applets/calculator/calculator.h f7339be =

  applets/calculator/calculator.cpp 6bc3ddc =

  applets/calculator/package/contents/ui/calculator.qml PRE-CREATION =

  applets/calculator/package/metadata.desktop PRE-CREATION =

  applets/calculator/plasma-applet-calculator.desktop 0760729 =

Diff: http://git.reviewboard.kde.org/r/107001/diff/

Testing
-------

Tested as both applet and popupapplet, with the Air theme and the Oxygen th=
eme. It isn't keyboard-focused as a popupapplet (the user has to click it).=
 Other than that, it seems to work fine.

Thanks,

Rom=C3=A1rio Rios

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107001/">http://git.reviewboard.kde.org/r/107001/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Romário Rios.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This diff replaces the C++ Calculator applet by its QMLfied version, \
which seems to be feature-par with the latter.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested as both applet and popupapplet, with the Air theme and the Oxygen \
theme. It isn&#39;t keyboard-focused as a popupapplet (the user has to click it). \
Other than that, it seems to work fine.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/calculator/CMakeLists.txt <span style="color: \
grey">(732145c)</span></li>

 <li>applets/calculator/calculator.h <span style="color: grey">(f7339be)</span></li>

 <li>applets/calculator/calculator.cpp <span style="color: \
grey">(6bc3ddc)</span></li>

 <li>applets/calculator/package/contents/ui/calculator.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/calculator/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/calculator/plasma-applet-calculator.desktop <span style="color: \
grey">(0760729)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107001/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 